You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/18 05:58:10 UTC
[GitHub] [spark] kjmrknsn opened a new pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
kjmrknsn opened a new pull request #30082:
URL: https://github.com/apache/spark/pull/30082
### What changes were proposed in this pull request?
This pull request changes the `sep` parameter's value from `:` to `;` in the example of `examples/src/main/python/sql/datasource.py`. This code snippet is shown on the Spark SQL Guide documentation. The `sep` parameter's value should be `;` since the data in https://github.com/apache/spark/blob/master/examples/src/main/resources/people.csv is separated by `;`.
### Why are the changes needed?
To fix the example code so that it can be executed properly.
### Does this PR introduce _any_ user-facing change?
Yes.
This code snippet is shown on the Spark SQL Guide documentation: https://spark.apache.org/docs/latest/sql-data-sources-load-save-functions.html#manually-specifying-options
### How was this patch tested?
By building the documentation and checking the Spark SQL Guide documentation manually in the local environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30082:
URL: https://github.com/apache/spark/pull/30082#issuecomment-711130559
Merged to master, branch-3.0 and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30082:
URL: https://github.com/apache/spark/pull/30082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30082:
URL: https://github.com/apache/spark/pull/30082#issuecomment-711121736
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30082:
URL: https://github.com/apache/spark/pull/30082#issuecomment-711121652
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30082: [MINOR][DOCS][EXAMPLE] Fix the Python manual_load_options_csv example
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30082:
URL: https://github.com/apache/spark/pull/30082#issuecomment-711121652
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org