[GitHub] [carbondata] jackylk commented on a change in pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns

[GitBox <gi...@apache.org>]

jackylk commented on a change in pull request #3525: [CARBONDATA-3626] Improve performance when load data into carbon table with lots of columns
URL: https://github.com/apache/carbondata/pull/3525#discussion_r360651114
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala
 ##########
 @@ -353,7 +353,8 @@ private class CarbonOutputWriter(path: String,
   def writeCarbon(row: InternalRow): Unit = {
     val data = new Array[AnyRef](fieldTypes.length + partitionData.length)
     var i = 0
-    while (i < fieldTypes.length) {
+    val fieldTypesLen = fieldTypes.length
+    while (i < fieldTypesLen) {
 
 Review comment:
   Is it really has difference after the change for lots of columns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services