[GitHub] [hudi] bvaradar commented on a change in pull request #1650: [HUDI-541]: replaced dataFile/df with baseFile/bf throughout code base

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #1650:
URL: https://github.com/apache/hudi/pull/1650#discussion_r453221614



##########
File path: hudi-common/src/main/avro/HoodieCompactionOperation.avsc
##########
@@ -41,7 +41,7 @@
                      "default": null
                   },
                   {
-                     "name":"dataFilePath",
+                     "name":"baseFilePath",

Review comment:
       @pratyakshsharma : Alias should be the new name "baseFilePath". We need to keep the name unchanged here. I agree with @vinothchandar . We need to be very careful when changing serialized metadata entries. This includes
   1. Avro Model (*avsc )
   2. Serialized Model Classes - org.apache.hudi.common.model.HoodieCommitMetadata (not relevant for this change)
   
   Can you take a look at TestHoodieCommitMetadata to see an example of how we test backwards compatibility. We would need to do something similar for this change. 
   
   
   
   
   

##########
File path: hudi-client/src/main/java/org/apache/hudi/table/action/rollback/MergeOnReadRollbackActionExecutor.java
##########
@@ -124,7 +124,7 @@ public MergeOnReadRollbackActionExecutor(JavaSparkContext jsc,
         case HoodieTimeline.COMMIT_ACTION:
           LOG.info("Rolling back commit action. There are higher delta commits. So only rolling back this instant");
           partitionRollbackRequests.add(
-              RollbackRequest.createRollbackRequestWithDeleteDataAndLogFilesAction(partitionPath, instantToRollback));
+              RollbackRequest.createRollbackRequestWithDeleteBaseAndLogFilesAction(partitionPath, instantToRollback));

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org