You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/03/13 16:17:08 UTC
Review Request 57561: Empty current and recommended values in
"Recommended configs" panel during Add Service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57561/
-----------------------------------------------------------
Review request for Ambari and Oleg Nechiporenko.
Bugs: AMBARI-20425
https://issues.apache.org/jira/browse/AMBARI-20425
Repository: ambari
Description
-------
In some cases current and recommended value cells in dependent configs table are both empty and have got less than minimal cell height.
The behaviour should be as follows:
- When a new property is being added, show "Property undefined" in italics on the left column with gray background (and the value in the right column).
- When an existing property is being removed, show "Property removed" in italics on the right column with gray background (and the existing value in the left column).
- When an existing property value changes, we just show the changes without color coding except where the value itself is multi-line. Sometimes the source/target value is empty. In this scenario we just show an empty box (as opposed to gray background when a property is being added or removed as described above).
Diffs
-----
ambari-web/app/messages.js 2e80a2b
ambari-web/app/styles/application.less 8a15fb1
ambari-web/app/views/common/configs/config_diff_view.js 135efb7
Diff: https://reviews.apache.org/r/57561/diff/1/
Testing
-------
20559 passing (18s)
153 pending
Thanks,
Andrii Babiichuk
Re: Review Request 57561: Empty current and recommended values in
"Recommended configs" panel during Add Service
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57561/#review168777
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On March 13, 2017, 4:17 p.m., Andrii Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57561/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 4:17 p.m.)
>
>
> Review request for Ambari and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-20425
> https://issues.apache.org/jira/browse/AMBARI-20425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In some cases current and recommended value cells in dependent configs table are both empty and have got less than minimal cell height.
> The behaviour should be as follows:
>
> - When a new property is being added, show "Property undefined" in italics on the left column with gray background (and the value in the right column).
> - When an existing property is being removed, show "Property removed" in italics on the right column with gray background (and the existing value in the left column).
> - When an existing property value changes, we just show the changes without color coding except where the value itself is multi-line. Sometimes the source/target value is empty. In this scenario we just show an empty box (as opposed to gray background when a property is being added or removed as described above).
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js 2e80a2b
> ambari-web/app/styles/application.less 8a15fb1
> ambari-web/app/views/common/configs/config_diff_view.js 135efb7
>
>
> Diff: https://reviews.apache.org/r/57561/diff/1/
>
>
> Testing
> -------
>
> 20559 passing (18s)
> 153 pending
>
>
> Thanks,
>
> Andrii Babiichuk
>
>