You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by bu...@apache.org on 2002/10/11 17:24:05 UTC

DO NOT REPLY [Bug 12841] - GenericObjectPool unused variable and unused synchronized block

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12841>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12841

GenericObjectPool unused variable and unused synchronized block





------- Additional Comments From rwaldhof@us.britannica.com  2002-10-11 15:24 -------
I think the intention may have been to use sleeptime, and to assign it in a 
syncrhonized block in case _timeBetweenEvictionRuns was changed in the midst of 
the assignment.

In the current impl, this line is potentially problematic:
      Thread.currentThread().sleep(_timeBetweenEvictionRunsMillis);
if _timeBetweenEvictionRuns is changing (as a long, non-atomicly), it could be 
some funky value at the time of the read.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>