You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/17 09:37:34 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports

EricGao888 opened a new issue, #12401:
URL: https://github.com/apache/dolphinscheduler/issues/12401

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   *  Spotless sometimes fails to detect and block wildcard imports, see: https://github.com/apache/dolphinscheduler/pull/12076#discussion_r996636015
   
   ### What you expected to happen
   
   * Spotless should be able to detect and block wildcard imports in code.
   
   ### How to reproduce
   
   * WIP, will update this section later.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12401:
URL: https://github.com/apache/dolphinscheduler/issues/12401#issuecomment-1280754276

   When #11412 is done, this issue will get fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12401:
URL: https://github.com/apache/dolphinscheduler/issues/12401#issuecomment-1280678952

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 closed issue #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports

Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports
URL: https://github.com/apache/dolphinscheduler/issues/12401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #12401: [Bug][Style] Spotless sometimes fails to detect and block wildcard imports

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12401:
URL: https://github.com/apache/dolphinscheduler/issues/12401#issuecomment-1280921812

   > When #11412 is done, this issue will get fixed.
   
   After reconsideration, instead of tangling with `ratchetFrom`, I believe a better way is to fix all the legacy style errors once for all. We have been using `Spotless` for several months and most style errors have been fixed. Now it's a good time to fix the rest and it will also help maintainer review PR more easily without bothered by those style fix. I will submit a PR later this week to do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org