[GitHub] lovelyelfpop edited a comment on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled

[GitBox <gi...@apache.org>]

lovelyelfpop edited a comment on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-446804168
 
 
   On iphoneX
   
   for `[self.webView setFrame:CGRectMake(self.webView.frame.origin.x, TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width, self.webView.frame.size.height)];`,
   the webview is out of the screen at the bottom, it seems the webview's height is 20px higher than it should be.
   
   for `[self.webView setFrame:CGRectMake(self.webView.frame.origin.x, TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width, self.webView.frame.size.height - [self getStatusBarOffset])];`,
   it leaves 20px grey area at the bottom, the webview's height is 20px shorter than it should be.
   
   Could it be `[self.webView setFrame:CGRectMake(self.webView.frame.origin.x, TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width, self.webView.frame.size.height - [self getStatusBarOffset] + STATUSBAR_HEIGHT)];`, because the viewbounds height is subtracted by `STATUSBAR_HEIGHT` in `viewWillApear`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org