[GitHub] [hive] ShubhamChaurasia commented on a change in pull request #2391: HIVE-25243: Llap external client - Handle nested values when the parent struct is null

[GitBox <gi...@apache.org>]

ShubhamChaurasia commented on a change in pull request #2391:
URL: https://github.com/apache/hive/pull/2391#discussion_r655425247



##########
File path: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapVectorArrow.java
##########
@@ -238,7 +238,10 @@ public void testDataTypes() throws Exception {
     assertEquals(Date.valueOf("2013-01-01"), rowValues[19]);
     assertEquals("abc123", rowValues[20]);
     assertEquals("abc123         ", rowValues[21]);
-    assertArrayEquals("X'01FF'".getBytes("UTF-8"), (byte[]) rowValues[22]);
+
+    // one of the above assertions already has assertEquals(null, rowValues[22])
+    // and below assertion fails with - java.lang.AssertionError: actual array was null
+    // assertArrayEquals("X'01FF'".getBytes("UTF-8"), (byte[]) rowValues[22]);

Review comment:
       ah yes, right I missed that, will create a new test altogether for this as suggested in other comments too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org