You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/20 23:02:21 UTC
Review Request: Eliminated empty Try constructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4420/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Summary
-------
See summary.
Diffs
-----
src/common/try.hpp a4b9eb2
src/launcher/executor.cpp 30a0bb9
Diff: https://reviews.apache.org/r/4420/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Eliminated empty Try constructor.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-20 22:04:30, John Sirois wrote:
> > I certainly like this much better!
No worries, thanks for the push back!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4420/#review6146
-----------------------------------------------------------
On 2012-03-20 22:02:21, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4420/
> -----------------------------------------------------------
>
> (Updated 2012-03-20 22:02:21)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/try.hpp a4b9eb2
> src/launcher/executor.cpp 30a0bb9
>
> Diff: https://reviews.apache.org/r/4420/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Eliminated empty Try constructor.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4420/#review6146
-----------------------------------------------------------
Ship it!
I certainly like this much better!
- John
On 2012-03-20 22:02:21, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4420/
> -----------------------------------------------------------
>
> (Updated 2012-03-20 22:02:21)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/try.hpp a4b9eb2
> src/launcher/executor.cpp 30a0bb9
>
> Diff: https://reviews.apache.org/r/4420/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>