You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/05/01 18:14:21 UTC
Re: Review Request 58766: Fixed coding style issues in
ProvisionerDockerBackendTest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58766/
-----------------------------------------------------------
(Updated May 1, 2017, 6:14 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway.
Changes
-------
Addressed Jie's comment.
Summary (updated)
-----------------
Fixed coding style issues in ProvisionerDockerBackendTest.
Repository: mesos
Description (updated)
-------
Replaced a string concatenation with path::join() and
a shell echo command with os::write() in
ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_Overwrite.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 52e57cef81f79ebae4d5305708929396c5d75680
Diff: https://reviews.apache.org/r/58766/diff/2/
Changes: https://reviews.apache.org/r/58766/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 58766: Fixed coding style issues in
ProvisionerDockerBackendTest.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58766/#review173507
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58764, 58766]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 1, 2017, 6:14 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58766/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 6:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced a string concatenation with path::join() and
> a shell echo command with os::write() in
> ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_Overwrite.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 52e57cef81f79ebae4d5305708929396c5d75680
>
>
> Diff: https://reviews.apache.org/r/58766/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>