[jira] [Commented] (CASSANDRA-10113) Undroppable messages can be dropped if message queue gets large

["Brandon Williams (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935419#comment-14935419 ] 

Brandon Williams commented on CASSANDRA-10113:
----------------------------------------------

lgtm, +1

> Undroppable messages can be dropped if message queue gets large
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-10113
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10113
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 2.1.x
>
>
> When outgoing messages are queued, OutboundTcpConnection checks the size of backlog, and [if it gets more than 1024, it drops expired messages silently from the backlog|https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L150].
> {{expireMessages()}} just checks message's timeout, which can be {{request_timeout_in_ms}} (10 sec default) for non- read/write message, and does not check if its droppable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)