You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jgoz (via GitHub)" <gi...@apache.org> on 2023/02/07 00:27:02 UTC
[GitHub] [druid] jgoz opened a new pull request, #13762: Upgrade typescript and other dependencies
jgoz opened a new pull request, #13762:
URL: https://github.com/apache/druid/pull/13762
### Description
Upgrade the following:
- Typescript to 4.9
- Zustand to 4.x
- typescript-eslint to latest
Lint changes:
- Add 'consistent-type-imports' rule to automatically use `import type` where possible
Test changes:
- Drop enzyme for [react-shallow-renderer](https://www.npmjs.com/package/react-shallow-renderer) for future proofing since it supports React 18 and enzyme does not/will not
- The serialized snapshots have some slight differences compared to enzyme, but they largely capture the same details. The big omission is `key` props, but we can probably live without those.
This PR has:
- [x] been self-reviewed.
- [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #13762: Upgrade typescript and other dependencies
Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky merged PR #13762:
URL: https://github.com/apache/druid/pull/13762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org