You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sander Verhagen (JIRA)" <ji...@codehaus.org> on 2008/08/03 03:17:26 UTC

[jira] Created: (MPH-42) Active profiles recursively growing

Active profiles recursively growing
-----------------------------------

                 Key: MPH-42
                 URL: http://jira.codehaus.org/browse/MPH-42
             Project: Maven 2.x Help Plugin
          Issue Type: Bug
    Affects Versions: 2.0.2, 2.1
            Reporter: Sander Verhagen
            Priority: Critical
         Attachments: Active-profiles-recursively-growing.diff.txt

Running the active-profiles goal in a project where parents introduce profiles, any sub-modules of these parents will report a number of duplicates of these profiles that grows each time the goal is invoked.

This is caused by the plugin (recursively) retrieving profiles from subsequent parents, and adding them to the project on which the goal is invoked. The plugin means to add the profiles that it finds so that it can give an aggregated listing of profiles over the full inheritance tree of the project on which the goal is invoked (which is okay), it is mistaken in actually adding them to the project on which the goal is invoked. It changes the project on which the goal is invoked, rather than merely observing it. Because the plugin keeps on adding the same profiles from parent projects, every time it is invoked, to the same project on which the goal is invoked, the aggregated listing keeps on growing and growing during execution.

Rated this Critical since on large projects this renders the plugin useless; the output will become booming; well, you know how that goes with recursion.

Fix is attached as unified diff.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MPH-42) Active profiles recursively growing

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPH-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton closed MPH-42.
------------------------------

         Assignee: Vincent Siveton
       Resolution: Fixed
    Fix Version/s: 2.1

Patch applied in [r682181|http://svn.apache.org/viewvc?rev=682181&view=rev], snapshot deployed. Thanks!

> Active profiles recursively growing
> -----------------------------------
>
>                 Key: MPH-42
>                 URL: http://jira.codehaus.org/browse/MPH-42
>             Project: Maven 2.x Help Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0.2, 2.1
>            Reporter: Sander Verhagen
>            Assignee: Vincent Siveton
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: Active-profiles-recursively-growing.diff.txt
>
>
> Running the active-profiles goal in a project where parents introduce profiles, any sub-modules of these parents will report a number of duplicates of these profiles that grows each time the goal is invoked.
> This is caused by the plugin (recursively) retrieving profiles from subsequent parents, and adding them to the project on which the goal is invoked. The plugin means to add the profiles that it finds so that it can give an aggregated listing of profiles over the full inheritance tree of the project on which the goal is invoked (which is okay), it is mistaken in actually adding them to the project on which the goal is invoked. It changes the project on which the goal is invoked, rather than merely observing it. Because the plugin keeps on adding the same profiles from parent projects, every time it is invoked, to the same project on which the goal is invoked, the aggregated listing keeps on growing and growing during execution.
> Rated this Critical since on large projects this renders the plugin useless; the output will become booming; well, you know how that goes with recursion.
> Fix is attached as unified diff.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira