[GitHub] [nifi] exceptionfactory commented on pull request #6024: NIFI-9999 Refactor MiNiFi tests using JUnit 5

[GitBox <gi...@apache.org>]

exceptionfactory commented on PR #6024:
URL: https://github.com/apache/nifi/pull/6024#issuecomment-1121278801

   Thanks for the feedback @bejancsaba!
   
   As far as AssertJ, it is licensed under Apache License 2.0, so that's good. JUnit 5 included some improvements in terms of assertion capabilities, so I would recommend staying with it, given that no other modules currently use AssertJ.  Part of the effort in moving to JUnit 5 has involved bringing more consistency to tests, such as using static imports and replacing `fail()` assertions with `assertThrows()`. More complex assertions might be helpful to handle using AssertJ, but it could also create inconsistency in terms of different approaches. This seems like a good question to raise on the developer mailing list, or on the dev Slack channel.
   
   Thanks for mentioning the JUnit 4 dependency in the MiNiFi Maven configuration, that can be removed, so I have pushed another commit to update pom.xml.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org