You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/19 13:53:10 UTC
[GitHub] TisonKun commented on a change in pull request #6717:
[FLINK-10369][tests] Enable YARNITCase to test per job mode deployment
TisonKun commented on a change in pull request #6717: [FLINK-10369][tests] Enable YARNITCase to test per job mode deployment
URL: https://github.com/apache/flink/pull/6717#discussion_r218803183
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##########
@@ -79,20 +86,45 @@ public void testPerJobMode() throws Exception {
env.addSource(new InfiniteSource())
.shuffle()
- .addSink(new DiscardingSink<Integer>());
+ .addSink(new DiscardingSink<>());
final JobGraph jobGraph = env.getStreamGraph().getJobGraph();
File testingJar = YarnTestBase.findFile("..", new TestingYarnClusterDescriptor.TestJarFinder("flink-yarn-tests"));
Review comment:
`TestingYarnClusterDescriptor` is inherited from `LegacyYarnClusterDescriptor` and should be removed. Here we rely on `TestingYarnClusterDescriptor.TestJarFinder`, which is a util class, and could move it into `YarnTestUtils` to release such dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services