You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Brendan Chang <bs...@mesosphere.io> on 2015/06/30 00:56:35 UTC
Review Request 36026: Fixed typo in slave flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
Diff: https://reviews.apache.org/r/36026/diff/
Testing
-------
Thanks,
Brendan Chang
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89816
-----------------------------------------------------------
Valid typo. Improper fix. You could try again, or I could just push the right fix.
src/slave/flags.cpp (line 284)
<https://reviews.apache.org/r/36026/#comment142610>
s/that //
- Adam B
On June 29, 2015, 3:56 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36026/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 3:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
>
> Diff: https://reviews.apache.org/r/36026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89817
-----------------------------------------------------------
src/slave/flags.cpp (line 284)
<https://reviews.apache.org/r/36026/#comment142611>
s/that //
or
s/that the/ that of the/
- Kapil Arya
On June 29, 2015, 6:56 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36026/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
>
> Diff: https://reviews.apache.org/r/36026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89820
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On June 29, 2015, 4:03 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36026/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 4:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
>
> Diff: https://reviews.apache.org/r/36026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89818
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On June 29, 2015, 11:03 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36026/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 11:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
>
> Diff: https://reviews.apache.org/r/36026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89819
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On June 29, 2015, 7:03 p.m., Brendan Chang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36026/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 7:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
>
> Diff: https://reviews.apache.org/r/36026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brendan Chang
>
>
Re: Review Request 36026: Fixed typo in slave flags.
Posted by Brendan Chang <bs...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/
-----------------------------------------------------------
(Updated June 29, 2015, 11:03 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Changes
-------
Fixed another typo.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0
Diff: https://reviews.apache.org/r/36026/diff/
Testing
-------
Thanks,
Brendan Chang