You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "justinpakzad (via GitHub)" <gi...@apache.org> on 2026/01/05 00:37:09 UTC
[PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
justinpakzad opened a new pull request, #60110:
URL: https://github.com/apache/airflow/pull/60110
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Made sqlalchemy an optional dependency for the Databricks provider. `AirflowOptionalProviderFeatureException()` gets raised if it's not installed. Just a quick note - Databricks uses the `databricks-sqlalchemy` package, since it's now an optional dependency, I needed to add it to the dev dependencies to ensure the tests that rely on it work properly.
closes: #59900
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60110:
URL: https://github.com/apache/airflow/pull/60110#issuecomment-3710388313
I think, the compat tests are failing because of an interesting side-effect of making databricks-sqlalchemy optional. What happens is that we we are installing "dev" dependencies with airflow 3 -> so latest databrics-sqlalchemy is installed (2.0.8) - because it supports sqlalchemy 2 (and airflow 3.2 already supports it). Then when later airflow 2 or 3 versions are installed, they bring the sqlalchemy to 1 (because they do not support 2) but they do not bring databricks-sqlalchemy down, when databricks provider is installed then (without sqlalchemy extra) - it also will not bring the databricks-sqlalchemy down :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #60110:
URL: https://github.com/apache/airflow/pull/60110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60110:
URL: https://github.com/apache/airflow/pull/60110#issuecomment-3710413851
I wil send a workaround shortly for that "optional sqlalchemy extra" soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on PR #60110:
URL: https://github.com/apache/airflow/pull/60110#issuecomment-3710462204
Thanks for chiming in. Will update the PR w the changes once you send the workaround patch over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60110:
URL: https://github.com/apache/airflow/pull/60110#issuecomment-3712009451
Fixup pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60110:
URL: https://github.com/apache/airflow/pull/60110#discussion_r2666101229
##########
providers/databricks/docs/index.rst:
##########
Review Comment:
We should likely add automated generation of the optional deps here :) - but that's something separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #60110:
URL: https://github.com/apache/airflow/pull/60110#discussion_r2661433138
##########
providers/databricks/pyproject.toml:
##########
@@ -107,6 +109,7 @@ dev = [
"apache-airflow-providers-microsoft-azure",
"apache-airflow-providers-common-sql[pandas,polars]",
"apache-airflow-providers-fab",
+ "databricks-sqlalchemy>=1.0.2",
Review Comment:
```suggestion
"apache-airflow-providers-databricks[sqlalchemy]",
```
Then you do not have to maintain version in two places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Made sqlalchemy dependency optional for Databricks provider [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on PR #60110:
URL: https://github.com/apache/airflow/pull/60110#issuecomment-3712076355
> Fixup pushed
Thanks for that. I wasn't sure if I was meant to make the change so I was waiting to update the `"databricks-sqlalchemy>=1.0.2"` dependency. Let me update that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org