[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #993: Oak 10199 : Added Skeleton & Deteled garbage Properties

["rishabhdaim (via GitHub)" <gi...@apache.org>]

rishabhdaim commented on code in PR #993:
URL: https://github.com/apache/jackrabbit-oak/pull/993#discussion_r1285719000


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java:
##########
@@ -73,35 +89,57 @@ public class VersionGCRecommendations {
      * @param vgc VersionGC support class
      * @param options options for running the gc
      * @param gcMonitor monitor class for messages
+     * @param detailedGCEnabled whether detailedGC is enabled or not
      */
     public VersionGCRecommendations(long maxRevisionAgeMs, Checkpoints checkpoints, Clock clock, VersionGCSupport vgc,
-            VersionGCOptions options, GCMonitor gcMonitor) {
+                                    VersionGCOptions options, GCMonitor gcMonitor, final boolean detailedGCEnabled) {

Review Comment:
   @ stefan-egli I looked into the code and creating a new `Recommendations` class for `DetailedGC` would complicate the code readability.
   
   However, If felt needed, later on, we can separate out the logic. As of now, I would keep them in the same class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org