[GitHub] [incubator-superset] zuzana-vej commented on issue #10655: Saving metadata in Dashboard properties is broken

[GitBox <gi...@apache.org>]

zuzana-vej commented on issue #10655:
URL: https://github.com/apache/incubator-superset/issues/10655#issuecomment-712528282


   No, it didn't. Right now, (after #11220 merged) this is what happens if user tries to edit dashboard metadata (e.g. best way to test this on your test dashboard is to change color of one of the lines on your chart in the dashboard metadata tab).
   
   Right now, what happens, is:
   1. user edits metatada (e.g. change color of a line on a chart)
   2. user clicks save on modal (all good)
   3. user clicks save on dashboard --> and gets the message "this dashboard has changed, please reload"
   4. when user reloads, the change is actually applied
   
   So in a way it solves the issue - change is applied, but user currently gets a warning message which will confuse them.
   
   cc: @graceguo-supercat 
   
   High level I do agree we don't have to build the perfect long term solution since there are planned improvements. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org