[jira] [Resolved] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

["Thomas D'Silva (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas D'Silva resolved PHOENIX-2756.
-------------------------------------
    Resolution: Fixed

> FilteredKeyValueScanner should not implement KeyValueScanner
> ------------------------------------------------------------
>
>                 Key: PHOENIX-2756
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2756
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 4.8.0
>            Reporter: churro morales
>            Assignee: churro morales
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2756-4.x-HBase-0.98.patch, PHOENIX-2756-addendum.patch, PHOENIX-2756.patch
>
>
> In HBASE-14355, the API for KeyValueScanner changed.  More specifically the method shouldUseScanner() had a signature change.  Phoenix has a class: FilteredKeyValueScanner which implements KeyValueScanner.  For HBase 98, I will put up a patch that doesn't change the API signature ( a little hacky) but this signature change is already in HBase-1.2+.  Either we can raise the scope of KeyValueScanner to @LimitedPrivate in HBase land.  Right now its @Private so people don't assume that external services are depending on the API.  I'll look into how we can make things work in Phoenix land.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)