[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…
URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301439217
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/utils/JsonUtils.java
 ##########
 @@ -137,13 +138,15 @@ public static Object extractValue(@Nullable JsonNode jsonValue, FieldSpec fieldS
             }
             return values;
           } else {
-            return new Object[]{fieldSpec.getDefaultNullValue()};
+            return null;
 
 Review comment:
   I dint follow. I am doing something similar to this in NullValueTransformer
   ```
             row.putField(fieldName, new Object[]{fieldSpec.getDefaultNullValue()});
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org