You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/09 04:33:39 UTC
[GitHub] [camel-k] bouskaJ opened a new pull request #2198: Add OLM upgrade test
bouskaJ opened a new pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-817509796
@astefanutti can you rerun the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-821229670
Hi, @astefanutti yes, there is no `replaces` but the replace scenario is forced by the `skipRange` (see https://github.com/apache/camel-k/blob/master/.github/workflows/upgrade.yml#L138).
I was considering:
- `replaces` because it was close to the real upstream releases
- `skipRange` - used in the internal stream (at the day I was writing the test)
I decided on the `skipRange` because it is able to force an upgrade on the older releases as well so the test is not dependent on the **very last release** -> devel version. I think we can migrate to `replaces` since both streams use `replaces` at the moment in the real manifests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-816530006
> > @bouskaJ awesome!
> > It's possible that CI is currently broken as the Camel / Camel Quarkus upgrade is being rolling out and needs #2197 to complete.
>
> Yes, we may merge #2197 to have less errors, as the only issue seems in runtime: [apache/camel-k-runtime#651](https://github.com/apache/camel-k-runtime/issues/651). Wdyt?
Good idea, +1 for me, then we can rebase the pending PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-816431810
@astefanutti the CI seems to be faulty. I see a lot of various errors that are not caused by my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-816394308
@astefanutti Finally, the PR is there. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-816502687
@bouskaJ awesome!
It's possible that CI is currently broken as the Camel / Camel Quarkus upgrade is being rolling out and needs #2197 to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-816521423
> @bouskaJ awesome!
>
> It's possible that CI is currently broken as the Camel / Camel Quarkus upgrade is being rolling out and needs #2197 to complete.
Yes, we may merge https://github.com/apache/camel-k/pull/2197 to have less errors, as the only issue seems in runtime: https://github.com/apache/camel-k-runtime/issues/651. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro merged pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-821233848
I am not sure why, it's failing. Maybe, the OLM needs more time to start the upgrade and we should use `TestTimeoutLong` https://github.com/apache/camel-k/blob/master/e2e/upgrade/olm_upgrade_test.go#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-821235173
Printing the patched CSV to the workflow log could help as well... (result of https://github.com/apache/camel-k/blob/master/.github/workflows/upgrade.yml#L143)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2198: Add OLM upgrade test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2198:
URL: https://github.com/apache/camel-k/pull/2198#issuecomment-817561274
@bouskaJ could you please rebase to have the changes from #2197 taken into account?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org