You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Oliver Klozoff <st...@fastmail.fm> on 2004/12/14 02:55:01 UTC
[PATCH] svnlook --revprop patch, take two
This patch adds --revprop support to svnlook propget and svnlook proplist.
It also adds more basic regression tests for other svnlook subcommands.
--- log-message-worthy content follows ---
* subversion/svnlook/main.c
(subcommand_plist, subcommand_pget):
Changed to pass NULL for the path argument to do_plist/do_pget
when --revprop is specified.
(do_plist, do_pget):
When the 'path' argument is NULL, switch from svn_fs_node_proplist/
svn_fs_node_prop to svn_fs_revision_proplist/svn_fs_revision_prop.
* subversion/tests/clients/cmdline/svnlook_tests.py
Added the following tests:
test_propget_revprop (tests svnlook propget --revprop)
test_propget_revprop_missing (tests svnlook --revprop
for a revision property that doesn't exist)
test_proplist_revprop (tests svnlook proplist --revprop)
test_uuid (tests svnlook uuid)
test_logmsg (tests svnlook log)
test_author (tests svnlook author)
* subversion/tests/clients/cmdline/svntest/main.py
Created function 'run_command_stdin'. Just like 'run_command',
except it allows the caller to specify data to be piped into
the command's stdin (needed by 'test_uuid').
Re: [PATCH] svnlook --revprop patch, take three
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Oliver Klozoff wrote:
> [Julian: Thank you for your patience and guidance :)]
>
> This patch adds --revprop support to svnlook propget and svnlook proplist.
> It also adds more basic regression tests for other svnlook subcommands.
Thanks for the patch. Since there didn't seem to be consensus about
whether to apply it, I went ahead and filed this patch as issue #2181:
http://subversion.tigris.org/issues/show_bug.cgi?id=2181
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
[PATCH] svnlook --revprop patch, take three
Posted by Oliver Klozoff <st...@fastmail.fm>.
[Julian: Thank you for your patience and guidance :)]
This patch adds --revprop support to svnlook propget and svnlook proplist.
It also adds more basic regression tests for other svnlook subcommands.
-- Stevie-O
Real programmers use COPY CON PROGRAM.EXE
--- log message follows ---
* subversion/svnlook/main.c
(subcommand_plist, subcommand_pget):
Pass NULL for the path argument to do_plist/do_pget
when --revprop is specified.
(do_plist, do_pget):
When the 'path' argument is NULL, switch from svn_fs_node_proplist/
svn_fs_node_prop to svn_fs_revision_proplist/svn_fs_revision_prop.
* subversion/tests/clients/cmdline/svnlook_tests.py
(test_propget_revprop): New. Tests 'svnlook propget --revprop'.
(test_propget_revprop_missing): New. 'Tests svnlook --revprop'
for a revision property that doesn't exist.
(test_proplist_revprop): New. Tests 'svnlook proplist --revprop'.
(test_uuid): New. Tests 'svnlook uuid'.
(test_logmsg): New. Tests 'svnlook log'.
(test_author): New. Tests 'svnlook author'.
(test_list): Added the new tests.
* subversion/tests/clients/cmdline/svntest/main.py
(run_command_stdin) New. Just like 'run_command',
except it allows the caller to specify data to be piped into
the command's stdin (needed by 'test_uuid').
Re: [PATCH] svnlook --revprop patch, take two
Posted by Julian Foad <ju...@btopenworld.com>.
Oliver Klozoff wrote:
> This patch adds --revprop support to svnlook propget and svnlook proplist.
> It also adds more basic regression tests for other svnlook subcommands.
I would adjust your log message to use only two spaces for indentation, and as
follows, and start with a summary based on your introduction above:
> --- log-message-worthy content follows ---
Add --revprop support to 'svnlook propget' and 'svnlook proplist'.
Add basic regression tests for these and other svnlook subcommands.
> * subversion/svnlook/main.c
> (subcommand_plist, subcommand_pget):
> Changed to pass NULL for the path argument to do_plist/do_pget
! Pass NULL for the 'path' argument to do_plist/do_pget
> when --revprop is specified.
>
> (do_plist, do_pget):
> When the 'path' argument is NULL, switch from svn_fs_node_proplist/
> svn_fs_node_prop to svn_fs_revision_proplist/svn_fs_revision_prop.
>
> * subversion/tests/clients/cmdline/svnlook_tests.py
> Added the following tests:
> test_propget_revprop (tests svnlook propget --revprop)
> test_propget_revprop_missing (tests svnlook --revprop
> for a revision property that doesn't exist)
> test_proplist_revprop (tests svnlook proplist --revprop)
> test_uuid (tests svnlook uuid)
> test_logmsg (tests svnlook log)
> test_author (tests svnlook author)
* subversion/tests/clients/cmdline/svnlook_tests.py
(test_propget_revprop): New. Tests 'svnlook propget --revprop'.
(test_propget_revprop_missing): New. Tests 'svnlook --revprop'
for a revision property that doesn't exist.
(test_proplist_revprop): New. Tests 'svnlook proplist --revprop'.
(test_uuid): New. Tests 'svnlook uuid'.
(test_logmsg): New. Tests 'svnlook log'.
(test_author): New. Tests 'svnlook author'.
(test_list): Add the new tests.
Or just
* subversion/tests/clients/cmdline/svnlook_tests.py
(test_propget_revprop, test_propget_revprop_missing, test_proplist_revprop,
test_uuid, test_logmsg, test_author): New.
(test_list): Add the new tests.
> * subversion/tests/clients/cmdline/svntest/main.py
> Created function 'run_command_stdin'. Just like 'run_command',
! (run_command_stdin): New. Just like 'run_command',
> except it allows the caller to specify data to be piped into
> the command's stdin (needed by 'test_uuid').
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by kf...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> > No, svnlook offers lots of stuff not available (or not easily
> > available) via the regular client.
>
> I'm looking at the output of 'svnlook help', and I don't see a single
> bit of information that 'svn' couldn't get. I'll grant you that some
> of info is definitely *inconvenient* to fetch via 'svn', but nothing's
> inaccessible.
Note the parenthetical portion of my claim.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by Ben Collins-Sussman <su...@collab.net>.
On Dec 15, 2004, at 12:09 PM, kfogel@collab.net wrote:
> Ben Collins-Sussman <su...@collab.net> writes:
>> By that argument, almost all of the 'svnlook' subcommands are
>> unnecessary, no?
>> Pretty much everything 'svnlook' does is doable via 'svn' with
>> file:/// access.
>
> No, svnlook offers lots of stuff not available (or not easily
> available) via the regular client.
>
I'm looking at the output of 'svnlook help', and I don't see a single
bit of information that 'svn' couldn't get. I'll grant you that some
of info is definitely *inconvenient* to fetch via 'svn', but nothing's
inaccessible.
I think we made a subtle design mistake in svnlook: we created a
handful of subcommands to retrieve specific unversioned props
('author', 'date', 'log'), when we should have just made a more generic
'propget' for unversioned props. As it stands right now, 'svnlook
propget' only retrieves versioned props. :-(
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by kf...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> By that argument, almost all of the 'svnlook' subcommands are
> unnecessary, no?
> Pretty much everything 'svnlook' does is doable via 'svn' with
> file:/// access.
No, svnlook offers lots of stuff not available (or not easily
available) via the regular client.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Dec 2004, Ben Collins-Sussman wrote:
>
> On Dec 14, 2004, at 11:08 AM, C. Michael Pilato wrote:
>
> > Is this patch necessary? I mean, if you can access a repos via
> > "/path/to/repos", then you can proplist and propget unversioned
> > properties on the server side by using the 'svn' binary and
> > "file:///path/to/repos".
> >
>
> By that argument, almost all of the 'svnlook' subcommands are
> unnecessary, no?
> Pretty much everything 'svnlook' does is doable via 'svn' with file:///
> access.
>
> I thought the point of 'svnlook' was to create a vague sense of
> comfort, knowing that it can only read a filesystem, not change one.
>
Also, if you have everything in svnlook except this missing feature, why
not add it?
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by Ben Collins-Sussman <su...@collab.net>.
On Dec 14, 2004, at 11:08 AM, C. Michael Pilato wrote:
> Oliver Klozoff <st...@fastmail.fm> writes:
>
>> This patch adds --revprop support to svnlook propget and svnlook
>> proplist.
>> It also adds more basic regression tests for other svnlook
>> subcommands.
>
> Is this patch necessary? I mean, if you can access a repos via
> "/path/to/repos", then you can proplist and propget unversioned
> properties on the server side by using the 'svn' binary and
> "file:///path/to/repos".
>
By that argument, almost all of the 'svnlook' subcommands are
unnecessary, no?
Pretty much everything 'svnlook' does is doable via 'svn' with file:///
access.
I thought the point of 'svnlook' was to create a vague sense of
comfort, knowing that it can only read a filesystem, not change one.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnlook --revprop patch, take two
Posted by "C. Michael Pilato" <cm...@collab.net>.
Oliver Klozoff <st...@fastmail.fm> writes:
> This patch adds --revprop support to svnlook propget and svnlook proplist.
> It also adds more basic regression tests for other svnlook subcommands.
Is this patch necessary? I mean, if you can access a repos via
"/path/to/repos", then you can proplist and propget unversioned
properties on the server side by using the 'svn' binary and
"file:///path/to/repos".
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org