You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/30 21:01:29 UTC
Review Request 71208: Revert "Updated cpplint to be compatible with
Python 3."
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
This patch was necessary when we were running cpplint in the python3
environment used e.g., also for bindings and other scripts. With
pre-commit we have freedom to choose the Python environment needed so we
can undo our adjustments here to stay closer to upstream.
Diffs
-----
support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
Diff: https://reviews.apache.org/r/71208/diff/1/
Testing
-------
* used for development for a couple of months
* reports no issues in the current source tree
Thanks,
Benjamin Bannier
Re: Review Request 71208: Revert "Updated cpplint to be compatible
with Python 3."
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217442
-----------------------------------------------------------
Ship it!
- Till Toenshoff
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
>
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71208/diff/3/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71208: Revert "Updated cpplint to be compatible
with Python 3."
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217286
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
>
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71208/diff/2/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71208: Revert "Updated cpplint to be compatible
with Python 3."
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217465
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 30, 2019, 2:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 2:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
>
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71208/diff/3/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71208: Revert "Updated cpplint to be compatible
with Python 3."
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71208/#review217269
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71208/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit 89db66e3df831eaa50fffb4149a3894097505c14.
>
> This patch was necessary when we were running cpplint in the python3
> environment used e.g., also for bindings and other scripts. With
> pre-commit we have freedom to choose the Python environment needed so we
> can undo our adjustments here to stay closer to upstream.
>
>
> Diffs
> -----
>
> support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8
>
>
> Diff: https://reviews.apache.org/r/71208/diff/2/
>
>
> Testing
> -------
>
> * used for development for a couple of months
> * reports no issues in the current source tree
>
>
> Thanks,
>
> Benjamin Bannier
>
>