[GitHub] nishantmonu51 commented on a change in pull request #6911: Remove DataSegmentFinder, InsertSegmentToDb, and descriptor.json file in deep storage

[GitBox <gi...@apache.org>]

nishantmonu51 commented on a change in pull request #6911: Remove DataSegmentFinder, InsertSegmentToDb, and descriptor.json file in deep storage
URL: https://github.com/apache/incubator-druid/pull/6911#discussion_r253947610
 
 

 ##########
 File path: extensions-contrib/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java
 ##########
 @@ -52,11 +52,9 @@ public void kill(DataSegment segment) throws SegmentLoadingException
     Map<String, Object> loadSpec = segment.getLoadSpec();
     final String bucket = MapUtils.getString(loadSpec, "bucket");
     final String indexPath = MapUtils.getString(loadSpec, "path");
-    final String descriptorPath = indexPath.substring(0, indexPath.lastIndexOf('/')) + "/descriptor.json";
 
     try {
       deleteIfPresent(bucket, indexPath);
-      deleteIfPresent(bucket, descriptorPath);
 
 Review comment:
   I think we might still need to have the code to delete the descriptor files in SegmentKillers, so that any segments which are created pre 0.14 release when deleted using kill tasks are completely killed.
   Can we keep the code to deal with deletion of descriptors and add a comment on why it is still kept ?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org