You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2009/12/11 18:03:18 UTC

[jira] Commented: (MAHOUT-217) Tidy up generated data after unit tests are run

    [ https://issues.apache.org/jira/browse/MAHOUT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789389#action_12789389 ] 

Sean Owen commented on MAHOUT-217:
----------------------------------

Agree with this. The right approach is a combination of:

- implementing tearDown() to do clean up
- using File.createTempFile() to make temp files, since it's guaranteed not to conflict
- calling .deleteOnExit() on temp Files to make sure the JVM just nukes them on exit for sure

Do you recall what exactly the culprit was? I can patch the proximate problem. Is if the fpgrowth business?

> Tidy up generated data after unit tests are run
> -----------------------------------------------
>
>                 Key: MAHOUT-217
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-217
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.3
>            Reporter: Isabel Drost
>             Fix For: 0.3
>
>
> I tried to compile Mahout on people.apache.org yesterday: The build failed at first, because tests could not generate test data. The reason: Some tests tried to generate test data at /tmp/<mahout-dir>/... - but those directories did exist already and belonged to Sean. Why? Probably because Sean had run the build earlier this year - but tests did not remove the data they generated.
> Proposed solution: Tests come with setup and with shutdown hooks. We should remove any data when a test is finished and shut down.
> Any thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.