[GitHub] [superset] codemaster08240328 commented on a diff in pull request #19370: fix(sql lab): replace the output column in the query history table

[GitBox <gi...@apache.org>]

codemaster08240328 commented on code in PR #19370:
URL: https://github.com/apache/superset/pull/19370#discussion_r843252798


##########
superset-frontend/src/SqlLab/components/QueryTable/index.tsx:
##########
@@ -35,10 +35,12 @@ import ResultSet from '../ResultSet';
 import HighlightedSql from '../HighlightedSql';
 import { StaticPosition, verticalAlign, StyledTooltip } from './styles';
 
-interface QueryTableQuery extends Omit<Query, 'state' | 'sql' | 'progress'> {
+interface QueryTableQuery
+  extends Omit<Query, 'state' | 'sql' | 'progress' | 'output' | 'results'> {

Review Comment:
   If you see the `Query`, there are a lot of other keys which we are not using for the table showing. 
   Do we need to omit all of them?
   
   Let's keep `output` if we don't need to change the type of `output`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org