You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/09 15:40:50 UTC

commons-pool git commit: [POOL-344] Delete repeated call startEvictor. Closes #5.

Repository: commons-pool
Updated Branches:
  refs/heads/master 2530447d5 -> 928b3e78d


[POOL-344] Delete repeated call startEvictor. Closes #5.

Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/928b3e78
Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/928b3e78
Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/928b3e78

Branch: refs/heads/master
Commit: 928b3e78daa0a16b53c275bf5bf0541cbe4f20d8
Parents: 2530447
Author: Gary Gregory <ga...@gmail.com>
Authored: Sat Jun 9 09:40:48 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Sat Jun 9 09:40:48 2018 -0600

----------------------------------------------------------------------
 src/changes/changes.xml                                           | 3 +++
 .../org/apache/commons/pool2/impl/GenericKeyedObjectPool.java     | 2 --
 .../java/org/apache/commons/pool2/impl/GenericObjectPool.java     | 2 --
 3 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-pool/blob/928b3e78/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 7d0bd85..2ffc867 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -65,6 +65,9 @@ The <action> type attribute can be add,update,fix,remove.
     <action dev="ggregory" issue="POOL-324" type="fix" due-to="Jay Xu, Gary Gregory">
       org.apache.commons.pool2.impl.GenericObjectPool.getFactoryType() throws java.lang.ClassCastException.
     </action>
+    <action dev="ggregory" issue="POOL-344" type="fix" due-to="Yulin Wang">
+      Delete repeated call startEvictor.
+    </action>
   </release>
   <release version="2.5.0" date="2017-12-16" description="This is a minor release, updating to Java 7.">
     <action dev="ggregory" issue="POOL-331" type="update">

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/928b3e78/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
index 066807a..5d269fe 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
@@ -112,8 +112,6 @@ public class GenericKeyedObjectPool<K,T> extends BaseGenericObjectPool<T>
         this.fairness = config.getFairness();
 
         setConfig(config);
-
-        startEvictor(getTimeBetweenEvictionRunsMillis());
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/commons-pool/blob/928b3e78/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
index b299320..2928c25 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
@@ -113,8 +113,6 @@ public class GenericObjectPool<T> extends BaseGenericObjectPool<T>
         idleObjects = new LinkedBlockingDeque<>(config.getFairness());
 
         setConfig(config);
-
-        startEvictor(getTimeBetweenEvictionRunsMillis());
     }
 
     /**