You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/10 15:07:42 UTC
[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #244: Adds
clock config logic and Kconfig menus for FLEXIO on IMXRT
NicholasChin opened a new pull request #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244
FLEXIO2 and FLEXIO3 use the same clock source, so that's why there isn't explicity Kconfig options or register setting logic for the FLEXIO3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #244: Adds clock
config logic and Kconfig menus for FLEXIO on IMXRT
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244#issuecomment-584453932
@davids5 Since you don't seem to have any technical issues with the change, I will go ahead and merge it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] NicholasChin commented on issue #244: Adds clock
config logic and Kconfig menus for FLEXIO on IMXRT
Posted by GitBox <gi...@apache.org>.
NicholasChin commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244#issuecomment-584321096
Hi David,
Thanks for the steps. Still getting used to working with with github. My PR is cleaned up and all Kconfig option combos build on 1020, 1050, and 1060-evk. I rebased onto the current master this morning before making my PR.
Nick
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #244: Adds clock
config logic and Kconfig menus for FLEXIO on IMXRT
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244#issuecomment-584187778
@NicholasChin - I can get to this later in the week. To speed getting this PR in please rebase on current master and run `tools/checkptach.sh -c 6da98a5` and fix any errors (a squash and force push is fine). Then build the evk 1020,1050 and 1062 `nsh` config and check for warnings or errors. Also ensure all the states of setting you have added will build cleanly with each config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #244: Adds clock
config logic and Kconfig menus for FLEXIO on IMXRT
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #244: Adds clock
config logic and Kconfig menus for FLEXIO on IMXRT
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #244: Adds clock config logic and Kconfig menus for FLEXIO on IMXRT
URL: https://github.com/apache/incubator-nuttx/pull/244#issuecomment-584168388
David is the i.MXRT guy on the team. I added him as the reviewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services