You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:50:21 UTC
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8342: Make some code more efficient
JackieTien97 commented on code in PR #8342:
URL: https://github.com/apache/iotdb/pull/8342#discussion_r1059278201
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ExpressionAnalyzer.java:
##########
@@ -1107,33 +1107,10 @@ public static boolean checkIsNeedTransform(Expression expression) {
/////////////////////////////////////////////////////////////////////////////////////////////////
public static String getDeviceNameInSourceExpression(Expression expression) {
- if (expression instanceof TernaryExpression) {
- String DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getFirstExpression());
- if (DeviceName == null) {
- DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getSecondExpression());
- }
- if (DeviceName == null) {
- DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getThirdExpression());
- }
- return DeviceName;
- } else if (expression instanceof BinaryExpression) {
- String leftDeviceName =
- getDeviceNameInSourceExpression(((BinaryExpression) expression).getLeftExpression());
- if (leftDeviceName != null) {
- return leftDeviceName;
- }
- return getDeviceNameInSourceExpression(((BinaryExpression) expression).getRightExpression());
- } else if (expression instanceof UnaryExpression) {
- return getDeviceNameInSourceExpression(((UnaryExpression) expression).getExpression());
- } else if (expression instanceof TimeSeriesOperand) {
+ if (expression instanceof TimeSeriesOperand) {
return ((TimeSeriesOperand) expression).getPath().getDevice();
} else if (expression instanceof FunctionExpression) {
- return getDeviceNameInSourceExpression(expression.getExpressions().get(0));
- } else if (expression instanceof ConstantOperand || expression instanceof TimestampOperand) {
- return null;
Review Comment:
why delete this branch?
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ExpressionAnalyzer.java:
##########
@@ -1107,33 +1107,10 @@ public static boolean checkIsNeedTransform(Expression expression) {
/////////////////////////////////////////////////////////////////////////////////////////////////
public static String getDeviceNameInSourceExpression(Expression expression) {
- if (expression instanceof TernaryExpression) {
- String DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getFirstExpression());
- if (DeviceName == null) {
- DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getSecondExpression());
- }
- if (DeviceName == null) {
- DeviceName =
- getDeviceNameInSourceExpression(((TernaryExpression) expression).getThirdExpression());
- }
- return DeviceName;
- } else if (expression instanceof BinaryExpression) {
- String leftDeviceName =
- getDeviceNameInSourceExpression(((BinaryExpression) expression).getLeftExpression());
- if (leftDeviceName != null) {
- return leftDeviceName;
- }
- return getDeviceNameInSourceExpression(((BinaryExpression) expression).getRightExpression());
- } else if (expression instanceof UnaryExpression) {
- return getDeviceNameInSourceExpression(((UnaryExpression) expression).getExpression());
- } else if (expression instanceof TimeSeriesOperand) {
+ if (expression instanceof TimeSeriesOperand) {
return ((TimeSeriesOperand) expression).getPath().getDevice();
} else if (expression instanceof FunctionExpression) {
- return getDeviceNameInSourceExpression(expression.getExpressions().get(0));
- } else if (expression instanceof ConstantOperand || expression instanceof TimestampOperand) {
- return null;
+ return ((TimeSeriesOperand) expression.getExpressions().get(0)).getPath().getDevice();
Review Comment:
why don't need to call `getDeviceNameInSourceExpression` recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org