[jira] [Commented] (FLINK-11449) Uncouple the Expression class from RexNodes

["Dawid Wysakowicz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758054#comment-16758054 ] 

Dawid Wysakowicz commented on FLINK-11449:
------------------------------------------

Ad.1 Here, I agree I think they should be in api-common as well, but I might be missing something...
Ad.2 Yes, I think those "new" api-facing Expressions should be in java, expressionDsl should be in scala as this is actually scala API, we might think of something equivalent in java in the future.
Ad.3 I think it can be in scala, as we map to old scala case classes, which will be much easier in scala.
Ad.4 Why should we treat CAST differently? This is just another function. I think we should aim to simplify expressions as much as possible. I see no reason to treat CAST any different. 

I don't think I get your suggestion to split Expressions and UDFs... There are already Expressions for UDFs calls, so we need to replace them as well. The whole work should be probably be split though in multiple commits(to make it easier to review), but not necessarily into multiple PRs/JIRAs.

> Uncouple the Expression class from RexNodes
> -------------------------------------------
>
>                 Key: FLINK-11449
>                 URL: https://issues.apache.org/jira/browse/FLINK-11449
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: sunjincheng
>            Priority: Major
>
> A more detailed description can be found in [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> Calcite will not be part of any API module anymore. Therefore, RexNode translation must happen in a different layer. This issue will require a new design document.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)