You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/16 13:29:36 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #9212: ARROW-11265: [Rust] Made bool not ArrowNativeType

nevi-me commented on a change in pull request #9212:
URL: https://github.com/apache/arrow/pull/9212#discussion_r558882578



##########
File path: rust/arrow/src/util/integration_util.rs
##########
@@ -449,12 +449,10 @@ impl ArrowJsonBatch {
                     for i in 0..col.len() {
                         if col.is_null(i) {
                             validity.push(1);

Review comment:
       This is unrelated, but unless I'm reading this incorrectly (likely am), I would have thought that we'd `validity.push(0)` here for null values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org