You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 06:21:38 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #26992: Support parsing Oracle ALTER TABLE sql

FlyingZC opened a new issue, #26992:
URL: https://github.com/apache/shardingsphere/issues/26992

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   ALTER TABLE table DEALLOCATE UNUSED KEEP integer;
   ALTER INDEX index DEALLOCATE UNUSED KEEP integer;
   ALTER CLUSTER cluster DEALLOCATE UNUSED KEEP integer;
   ```
   
   ```sql
   ALTER TABLE t1 MODIFY 
       LOB(a) (
            COMPRESS HIGH
       );
   ```
   
   ```sql
   ALTER TABLE table_name SET UNUSED (M_ROW$$);
   ```
   
   ```sql
   ALTER TABLE table_name MOVE NOCOMPRESS PARALLEL;
   ```
   
   ```sql
   ALTER TABLE time MODIFY CONSTRAINT pk_time RELY;
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #26992:
URL: https://github.com/apache/shardingsphere/issues/26992#issuecomment-1751986934

   Please assign the questions to me. Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on issue #26992:
URL: https://github.com/apache/shardingsphere/issues/26992#issuecomment-1757284231

   Error sql:
   
   SQL> ALTER TABLE table_test DEALLOCATE UNUSED KEEP integer;
   ALTER TABLE table_test DEALLOCATE UNUSED KEEP integer
                                                 *
   ERROR at line 1:
   ORA-03277: invalid SIZE specified
   
   SQL> ALTER INDEX index_test DEALLOCATE UNUSED KEEP integer;
   ALTER INDEX index_test DEALLOCATE UNUSED KEEP integer
                                                 *
   ERROR at line 1:
   ORA-03277: invalid SIZE specified
   
   SQL> ALTER CLUSTER cluster_test DEALLOCATE UNUSED KEEP integer;
   ALTER CLUSTER cluster_test DEALLOCATE UNUSED KEEP integer
                                                     *
   ERROR at line 1:
   ORA-03277: invalid SIZE specified


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #26992:
URL: https://github.com/apache/shardingsphere/issues/26992#issuecomment-1763636504

   Fixed by #https://github.com/apache/shardingsphere/pull/28716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #26992:
URL: https://github.com/apache/shardingsphere/issues/26992#issuecomment-1751993634

   @zihaoAK47 Assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #26992: Support parsing Oracle ALTER TABLE sql
URL: https://github.com/apache/shardingsphere/issues/26992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #26992: Support parsing Oracle ALTER TABLE sql

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #26992:
URL: https://github.com/apache/shardingsphere/issues/26992#issuecomment-1676081524

   There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org