You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/18 08:28:33 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev edited a comment on pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

hunyadi-dev edited a comment on pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#issuecomment-781153230


   > If you want to keep the librdkafka types as they are to more closely resemble their usage in C, I'm fine with that, otherwise here's a list of the remaining pointers parameters in the PR that are used in the body without a null check.
   
   I liked that the current interface is easy to match to the rdkafka api, but it is only a mild annoyance having to revisit this PR over and over, so I don't mind changing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org