You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "John Gordon (JIRA)" <ji...@apache.org> on 2012/10/21 12:14:11 UTC
[jira] [Created] (PIG-2995) Refactor unit test temporary file
allocation patterns to use FileLocalizer.getTemporaryPath
John Gordon created PIG-2995:
--------------------------------
Summary: Refactor unit test temporary file allocation patterns to use FileLocalizer.getTemporaryPath
Key: PIG-2995
URL: https://issues.apache.org/jira/browse/PIG-2995
Project: Pig
Issue Type: Bug
Components: build
Affects Versions: 0.10.0
Reporter: John Gordon
Priority: Minor
Pig unit tests have a lot of diverse patterns for temporary file allocation. Not all of them are best practices. There is an abstraction that could house best practices for test temporary file allocation -- FileLocalizer.getTemporaryPath. With this, we should be able to have all/most of the temporary file usage fall under just a few methods that can handle arbitrary pig contexts and provide more flexibility around testing pig with different fs implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2995) Refactor unit test temporary file
allocation patterns to use FileLocalizer.getTemporaryPath
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481900#comment-13481900 ]
Jonathan Coveney commented on PIG-2995:
---------------------------------------
I fully support this effort, and making the tests all follow best practices in general. Some of them are a mess!
> Refactor unit test temporary file allocation patterns to use FileLocalizer.getTemporaryPath
> -------------------------------------------------------------------------------------------
>
> Key: PIG-2995
> URL: https://issues.apache.org/jira/browse/PIG-2995
> Project: Pig
> Issue Type: Bug
> Components: build
> Affects Versions: 0.10.0
> Reporter: John Gordon
> Priority: Minor
>
> Pig unit tests have a lot of diverse patterns for temporary file allocation. Not all of them are best practices. There is an abstraction that could house best practices for test temporary file allocation -- FileLocalizer.getTemporaryPath. With this, we should be able to have all/most of the temporary file usage fall under just a few methods that can handle arbitrary pig contexts and provide more flexibility around testing pig with different fs implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira