[GitHub] [trafficserver] dragon512 commented on a change in pull request #7464: Upgrade Catch.hpp to v2.13.3

[GitBox <gi...@apache.org>]

dragon512 commented on a change in pull request #7464:
URL: https://github.com/apache/trafficserver/pull/7464#discussion_r567969874



##########
File path: proxy/http2/unit_tests/test_Http2Frame.cc
##########
@@ -39,13 +39,13 @@ TEST_CASE("Http2Frame", "[http2][Http2Frame]")
     uint8_t hdr_block_len = sizeof(hdr_block);
 
     Http2PushPromiseFrame frame(id, flags, pp, hdr_block, hdr_block_len);
-    uint64_t written = frame.write_to(miob);
+    int64_t written = frame.write_to(miob);
 
     CHECK(written == HTTP2_FRAME_HEADER_LEN + sizeof(Http2StreamId) + hdr_block_len);
     CHECK(written == miob_r->read_avail());
 
     uint8_t buf[32] = {0};
-    uint64_t read   = miob_r->read(buf, written);
+    int64_t read    = miob_r->read(buf, written);

Review comment:
       Just a quick question on this on this looked odd. should `miob_r->read(buf, written);` return an unsigned?
   
   or does it return a signed so you are changing uint64_t to init64_t to avoid a warning?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org