You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by maropu <gi...@git.apache.org> on 2018/03/16 06:27:18 UTC
[GitHub] incubator-hivemall pull request #137: [HIVEMALL-179][SPARK] Support spark-v2...
GitHub user maropu opened a pull request:
https://github.com/apache/incubator-hivemall/pull/137
[HIVEMALL-179][SPARK] Support spark-v2.3
## What changes were proposed in this pull request?
This pr supported the latest spark-v2.3.
## What type of PR is it?
Improvement
## What is the Jira issue?
https://issues.apache.org/jira/projects/HIVEMALL/issues/HIVEMALL-179
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/incubator-hivemall HIVEMALL-179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 04c3ce8ed8d8a9c3380c5bad9577dc2e9a8e378a
Author: Takeshi Yamamuro <ya...@...>
Date: 2018-03-16T06:24:49Z
Support spark-v2.3
----
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
yea, I still need to have some checks on the v2.3 integration. If I finished, I'll ping you.
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
merged to master
---
[GitHub] incubator-hivemall pull request #137: [HIVEMALL-179][SPARK] Support spark-v2...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/137
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
ok, ready to check. cc: @myui
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
@maropu Yes, let's drop spark-2.0 support in the next release. Please do it in another ticket.
FYI supported Spark version in EMR.
https://docs.aws.amazon.com/emr/latest/ReleaseGuide/images/emr-releases-5x.png
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
I was thinking we would drop the spark-2.0 support until the next release. ok? cc: @myui
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
@maropu Is this PR still WIP?
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
LGTM.
@maropu Could you merge this PR using `bin/merge_pr.py`?
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
CI failing due to `Failed to execute goal org.scalastyle:scalastyle-maven-plugin:0.8.0:check (default) on project hivemall-spark2.3: Failed during scalastyle execution: You have 8 Scalastyle violation(s). -> [Help 1]`
---
[GitHub] incubator-hivemall issue #137: [HIVEMALL-179][SPARK] Support spark-v2.3
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/137
ok.
---