You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2015/12/14 20:51:46 UTC

[jira] [Comment Edited] (SOLR-7730) speed-up faceting on doc values fields

    [ https://issues.apache.org/jira/browse/SOLR-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056595#comment-15056595 ] 

Steve Rowe edited comment on SOLR-7730 at 12/14/15 7:51 PM:
------------------------------------------------------------

[~mkhludnev], the changelog entry for this issue went into {{lucene/CHANGES.txt}} (despite the fact that it's a SOLR issue), but didn't make the 5.4 release.  However, it's still listed under the 5.3.0 section, despite the fact that it was never part of any 5.3.X release (see https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_3/lucene/CHANGES.txt and https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_4/lucene/CHANGES.txt)

The entry should be moved to the 5.4 section.

Thanks to randomstatistic on #solr IRC for mentioning this.


was (Author: steve_rowe):
[~mkhludnev], the changelog entry for this issue went into {{lucene/CHANGES.txt}} (despite the fact that it's a SOLR issue), but didn't make the 5.4 release.  However, it's still listed under the 5.3.0 section, despite the fact that it was never part of any 5.3.X release (see https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_3/lucene/CHANGES.txt )

The entry should be moved to the 5.4 section.

Thanks to randomstatistic on #solr IRC for mentioning this.

> speed-up faceting on doc values fields
> --------------------------------------
>
>                 Key: SOLR-7730
>                 URL: https://issues.apache.org/jira/browse/SOLR-7730
>             Project: Solr
>          Issue Type: Improvement
>          Components: faceting
>    Affects Versions: 5.2.1
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>              Labels: patch
>             Fix For: 5.4
>
>         Attachments: LUCENE-7730.patch, LUCENE-7730.patch, SOLR-7730.patch
>
>
> every time we count facets on DocValues fields in Solr on many segments index we see the unnecessary hotspot:
> {code}
> ....
>         at org.apache.lucene.index.MultiFields.getMergedFieldInfos(MultiFields.java:248)
>         at org.apache.lucene.index.SlowCompositeReaderWrapper.getFieldInfos(SlowCompositeReaderWrapper.java:239)
>         at org.apache.lucene.index.SlowCompositeReaderWrapper.getSortedSetDocValues(SlowCompositeReaderWrapper.java:176)
>         at org.apache.solr.request.DocValuesFacets.getCounts(DocValuesFacets.java:72)
>         at org.apache.solr.request.SimpleFacets.getTermCounts(SimpleFacets.java:460) ....
> {code}
> the reason is SlowCompositeReaderWrapper.getSortedSetDocValues() Line 136 and SlowCompositeReaderWrapper.getSortedDocValues() Line 174
> before return composite doc values, SCWR merges segment field infos, which is expensive, but after fieldinfo is merged, it checks *only* docvalue type in it. This dv type check can be done much easier in per segment basis. 
> This patch gets some performance gain for those who count DV facets in Solr.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org