You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/12/06 14:45:37 UTC

[GitHub] [systemds] fathollahzadeh opened a new pull request #1475: [IOGEN] Fixed IOGEN Test Path

fathollahzadeh opened a new pull request #1475:
URL: https://github.com/apache/systemds/pull/1475


   This commit makes "iogen" directory in "/test/scripts/functions" path when we don't have it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemds] fathollahzadeh commented on pull request #1475: [SYSTEMDS-3240] Fix IOGEN test path if the iogen directory doesn't exist

Posted by GitBox <gi...@apache.org>.
fathollahzadeh commented on pull request #1475:
URL: https://github.com/apache/systemds/pull/1475#issuecomment-987829696


   > Seems, a test related to this fails.
   > 
   > ```java
   > Running org.apache.sysds.test.functions.iogen.FrameGenerateReaderCSVTest
   > java.lang.Exception: The file format couldn't recognize!!
   > 	at org.apache.sysds.runtime.iogen.GenerateReader$GenerateReaderFrame.getReader(GenerateReader.java:114)
   > 	at org.apache.sysds.test.functions.iogen.GenerateReaderFrameTest.runGenerateReaderTest(GenerateReaderFrameTest.java:180)
   > ```
   
   
   
   > Seems, a test related to this fails.
   > 
   > ```java
   > Running org.apache.sysds.test.functions.iogen.FrameGenerateReaderCSVTest
   > java.lang.Exception: The file format couldn't recognize!!
   > 	at org.apache.sysds.runtime.iogen.GenerateReader$GenerateReaderFrame.getReader(GenerateReader.java:114)
   > 	at org.apache.sysds.test.functions.iogen.GenerateReaderFrameTest.runGenerateReaderTest(GenerateReaderFrameTest.java:180)
   > ```
   
   Thanks, @j143 - I fixed the tests and run all of them multiple times. The errors come up when I generate data with a random function; it seems some values had bad formats.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemds] j143 merged pull request #1475: [SYSTEMDS-3240] Fix IOGEN test path if the iogen directory doesn't exist

Posted by GitBox <gi...@apache.org>.
j143 merged pull request #1475:
URL: https://github.com/apache/systemds/pull/1475


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemds] j143 commented on pull request #1475: [IOGEN] Fixed IOGEN Test Path

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1475:
URL: https://github.com/apache/systemds/pull/1475#issuecomment-987699127


   Seems, a test related to this fails. 
   
   ```java
   Running org.apache.sysds.test.functions.iogen.FrameGenerateReaderCSVTest
   java.lang.Exception: The file format couldn't recognize!!
   	at org.apache.sysds.runtime.iogen.GenerateReader$GenerateReaderFrame.getReader(GenerateReader.java:114)
   	at org.apache.sysds.test.functions.iogen.GenerateReaderFrameTest.runGenerateReaderTest(GenerateReaderFrameTest.java:180)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org