You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/21 20:02:20 UTC
[commons-imaging] branch master updated: Remove redundant type casts.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
The following commit(s) were added to refs/heads/master by this push:
new 76521b66 Remove redundant type casts.
76521b66 is described below
commit 76521b669785ec4cc428587f4d30bacc7a42f13a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 21 16:02:16 2022 -0400
Remove redundant type casts.
---
src/main/java/org/apache/commons/imaging/common/RationalNumber.java | 6 ++----
.../org/apache/commons/imaging/formats/tiff/TiffRasterDataInt.java | 2 +-
.../commons/imaging/formats/tiff/datareaders/DataReaderStrips.java | 2 +-
src/main/java/org/apache/commons/imaging/internal/Util.java | 2 +-
4 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/main/java/org/apache/commons/imaging/common/RationalNumber.java b/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
index 3a2791d2..0aa226f6 100644
--- a/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
+++ b/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
@@ -286,10 +286,8 @@ public class RationalNumber extends Number {
for (int count = 0; bestOption.error > TOLERANCE
&& count < maxIterations; count++) {
final RationalNumber mediant = RationalNumber.factoryMethod(
- (long) low.rationalNumber.numerator
- + (long) high.rationalNumber.numerator,
- (long) low.rationalNumber.divisor
- + (long) high.rationalNumber.divisor);
+ low.rationalNumber.numerator + high.rationalNumber.numerator,
+ low.rationalNumber.divisor + high.rationalNumber.divisor);
final Option mediantOption = Option.factory(mediant, value);
if (value < mediant.doubleValue()) {
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataInt.java b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataInt.java
index 8a355418..f624c79a 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataInt.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffRasterDataInt.java
@@ -280,7 +280,7 @@ public class TiffRasterDataInt extends TiffRasterData {
public float[] getData() {
final float[] result = new float[nCells];
for (int i = 0; i < nCells; i++) {
- result[i] = (int) data[i];
+ result[i] = data[i];
}
return result;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
index fea2eb39..770587fe 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
@@ -402,7 +402,7 @@ public final class DataReaderStrips extends ImageDataReader {
width,
decompressed,
bitsPerPixel, byteOrder);
- transferBlockToRaster(0, yStrip, width, (int) rowsInThisStrip, blockData,
+ transferBlockToRaster(0, yStrip, width, rowsInThisStrip, blockData,
xRaster, yRaster, rasterWidth, rasterHeight, samplesPerPixel, rasterDataFloat);
}
return new TiffRasterDataFloat(rasterWidth, rasterHeight, samplesPerPixel, rasterDataFloat);
diff --git a/src/main/java/org/apache/commons/imaging/internal/Util.java b/src/main/java/org/apache/commons/imaging/internal/Util.java
index 7c02baad..c3bd6d7a 100644
--- a/src/main/java/org/apache/commons/imaging/internal/Util.java
+++ b/src/main/java/org/apache/commons/imaging/internal/Util.java
@@ -46,7 +46,7 @@ public class Util {
// This generics suppression is as good as the predicate given. If the predicate violates a generics design,
// then there will be an error during runtime.
private static ImageParser<?> getImageParser(final Predicate<ImageParser<?>> pred, final Supplier<? extends RuntimeException> supplier) {
- return (ImageParser<?>) ImageParser
+ return ImageParser
.getAllImageParsers()
.stream()
.filter(pred)