You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/29 08:58:01 UTC

[GitHub] [incubator-apisix] xxm404 opened a new issue #1627: bug: Document description does not match source code

xxm404 opened a new issue #1627:
URL: https://github.com/apache/incubator-apisix/issues/1627


   ### Issue description
   The limit-count plugin document description for `rejected_code` does not match source code 
   In document the rejected_code are optional, in source code the rejected_code are required
   ![image](https://user-images.githubusercontent.com/46340314/83240951-b2008400-a1cc-11ea-8d82-6628f4f89977.png)
   ![image](https://user-images.githubusercontent.com/46340314/83241023-cfcde900-a1cc-11ea-9d3d-c619894686bd.png)
   I can create PR to fix it, should i modify the document or source code
   ### Environment
   
   * apisix version (cmd: `apisix version`): 1.2
   * OS: ununtu 14.04
   
   
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   
   
   ### What's the expected result?
   Document should match the source code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1627: bug: Document description does not match source code

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1627:
URL: https://github.com/apache/incubator-apisix/issues/1627#issuecomment-635886888


   fix the document is better. Make it behave the same as the source code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis closed issue #1627: bug: Document description does not match source code

Posted by GitBox <gi...@apache.org>.
membphis closed issue #1627:
URL: https://github.com/apache/incubator-apisix/issues/1627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] xxm404 commented on issue #1627: bug: Document description does not match source code

Posted by GitBox <gi...@apache.org>.
xxm404 commented on issue #1627:
URL: https://github.com/apache/incubator-apisix/issues/1627#issuecomment-635876511


   Hi @membphis Should I modify the document to fix it or source code to fix it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1627: bug: Document description does not match source code

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1627:
URL: https://github.com/apache/incubator-apisix/issues/1627#issuecomment-635874113


   welcome PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org