[GitHub] [apisix-python-plugin-runner] SkyeYoung commented on pull request #55: fix: socket file permission

[GitBox <gi...@apache.org>]

SkyeYoung commented on PR #55:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/55#issuecomment-1250256803

   OK, I'll finish it soon.
   
   获取 Outlook for iOS<https://aka.ms/o0ukef>
   ________________________________
   发件人: 罗泽轩 ***@***.***>
   发送时间: Sunday, September 18, 2022 8:08:27 PM
   收件人: apache/apisix-python-plugin-runner ***@***.***>
   抄送: Young ***@***.***>; Author ***@***.***>
   主题: Re: [apache/apisix-python-plugin-runner] fix: socket file permission (PR #55)
   
   
   @spacewander commented on this pull request.
   
   ________________________________
   
   In apisix/runner/server/server.py<https://github.com/apache/apisix-python-plugin-runner/pull/55#discussion_r973710599>:
   
   > @@ -84,6 +84,12 @@ def __init__(self, config: NewServerConfig):
            self.sock.bind(self.fd)
            self.sock.listen(1024)
   
   +        # the default socket permission is 0755, which prevents the 'nobody' worker process
   +        # from writing to it if the APISIX is run under root.
   +        os.chmod(self.fd, 0o766)
   +        if os.stat(self.fd).st_mode & 0xfff != 0o766:
   +            raise Exception("can't change mode for unix socket permission to 766")
   
   
   Could you update the CI configuration so the e2e test can pass?
   We need to adjust the port of Admin API.
   
   ―
   Reply to this email directly, view it on GitHub<https://github.com/apache/apisix-python-plugin-runner/pull/55#pullrequestreview-1111533464>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALRIROF4QP6MSOGRG3XS3ALV64A3XANCNFSM6AAAAAAQOA3XPE>.
   You are receiving this because you authored the thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org