You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Emmanuel Venisse <em...@venisse.net> on 2006/07/19 14:14:31 UTC
Maven1 project converter
Hi,
I'm starting to migrate all the code from sandbox/plugins/maven-maven1-plugin to
maven-model-converter with some modifications on plugin configuration converter loading.
Dennis, do you work actually on maven-maven1-plugin?
Emmanuel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Emmanuel Venisse wrote:
> The mojo that we need to move under maven-one-plugin convert a m1
> project (project.xml+project.properties) to a m2 project. If some
> properties are found about some plugins in properties file, the plugin
> is added with the conf in the pom.xml too.
>
> maven-maven1-plugin allow to package a m1 plugin with m2
That is the maven-one-plugin.
The maven-maven1-plugin that's in the sandbox only handles the project
conversion. The mojo for this should be moved to the maven-one-plugin.
> Emmanuel
>
> Dion Gillard a écrit :
>> Guys,
>>
>> what does the plugin do?
>>
>> On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
>>>
>>>
>>> Dennis Lundberg a écrit :
>>> > Emmanuel Venisse wrote:
>>> >> Hi,
>>> >>
>>> >> I'm starting to migrate all the code from
>>> >> sandbox/plugins/maven-maven1-plugin to maven-model-converter with
>>> some
>>> >> modifications on plugin configuration converter loading.
>>> >>
>>> >> Dennis, do you work actually on maven-maven1-plugin?
>>> >
>>> > Oh sorry Emmanuel, I misread your mail the first time.
>>> >
>>> > I will check out maven-model-converter and see what you have done.
>>>
>>> yes, all the code is in maven-model-converter now. I need to merge it
>>> in maven 2.0.x branch, I'll do
>>> it tomorrow morning.
>>>
>>> >
>>> > There only seems to be the mojo left in the sandbox. I will have a
>>> look
>>> > at moving that to the maven-one-plugin and making it use the code that
>>> > has now moved to maven-model-converter. OK?
>>>
>>> The mojo is always in sandbox and we need to modify it, so it will
>>> use maven-model-converter, and
>>> yes, maven-one-plugin will be a better place for it.
>>>
>>> >
>>> > One other thing that I have left on my todo list, besides the stuff I
>>> > wrote about in the other mail, is to make the
>>> > PluginConfigurationConverters into plexus components.
>>>
>>> it's done :-)
>>>
>>> >
>>> > I have some other stuff that is not yet committed. Will go through it
>>> > and see how much there is and if it's ready to be checked in or not.
>>> >
>>> > Would it be possible for me to get svn write access to
>>> > maven-model-converter or do you prefer if I submit patches?
>>> >
>>>
>>> For the moment, you can send a patch and we'll see with the pmc if
>>> you can have access to
>>> maven-model-converter.
>>>
>>> Emmanuel
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
no, it allow only to package a m1 plugin with m2, not to run it.
Emmanuel
Dion Gillard a écrit :
> So does this mean m2 could run repackaged m1 plugins?
>
> On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
>> The mojo that we need to move under maven-one-plugin convert a m1 project
>> (project.xml+project.properties) to a m2 project. If some properties
>> are found about some plugins in
>> properties file, the plugin is added with the conf in the pom.xml too.
>>
>> maven-maven1-plugin allow to package a m1 plugin with m2
>>
>> Emmanuel
>>
>> Dion Gillard a écrit :
>> > Guys,
>> >
>> > what does the plugin do?
>> >
>> > On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
>> >>
>> >>
>> >> Dennis Lundberg a écrit :
>> >> > Emmanuel Venisse wrote:
>> >> >> Hi,
>> >> >>
>> >> >> I'm starting to migrate all the code from
>> >> >> sandbox/plugins/maven-maven1-plugin to maven-model-converter
>> with some
>> >> >> modifications on plugin configuration converter loading.
>> >> >>
>> >> >> Dennis, do you work actually on maven-maven1-plugin?
>> >> >
>> >> > Oh sorry Emmanuel, I misread your mail the first time.
>> >> >
>> >> > I will check out maven-model-converter and see what you have done.
>> >>
>> >> yes, all the code is in maven-model-converter now. I need to merge it
>> >> in maven 2.0.x branch, I'll do
>> >> it tomorrow morning.
>> >>
>> >> >
>> >> > There only seems to be the mojo left in the sandbox. I will have
>> a look
>> >> > at moving that to the maven-one-plugin and making it use the code
>> that
>> >> > has now moved to maven-model-converter. OK?
>> >>
>> >> The mojo is always in sandbox and we need to modify it, so it will use
>> >> maven-model-converter, and
>> >> yes, maven-one-plugin will be a better place for it.
>> >>
>> >> >
>> >> > One other thing that I have left on my todo list, besides the
>> stuff I
>> >> > wrote about in the other mail, is to make the
>> >> > PluginConfigurationConverters into plexus components.
>> >>
>> >> it's done :-)
>> >>
>> >> >
>> >> > I have some other stuff that is not yet committed. Will go
>> through it
>> >> > and see how much there is and if it's ready to be checked in or not.
>> >> >
>> >> > Would it be possible for me to get svn write access to
>> >> > maven-model-converter or do you prefer if I submit patches?
>> >> >
>> >>
>> >> For the moment, you can send a patch and we'll see with the pmc if you
>> >> can have access to
>> >> maven-model-converter.
>> >>
>> >> Emmanuel
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dion Gillard <di...@gmail.com>.
So does this mean m2 could run repackaged m1 plugins?
On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
> The mojo that we need to move under maven-one-plugin convert a m1 project
> (project.xml+project.properties) to a m2 project. If some properties are found about some plugins in
> properties file, the plugin is added with the conf in the pom.xml too.
>
> maven-maven1-plugin allow to package a m1 plugin with m2
>
> Emmanuel
>
> Dion Gillard a écrit :
> > Guys,
> >
> > what does the plugin do?
> >
> > On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
> >>
> >>
> >> Dennis Lundberg a écrit :
> >> > Emmanuel Venisse wrote:
> >> >> Hi,
> >> >>
> >> >> I'm starting to migrate all the code from
> >> >> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
> >> >> modifications on plugin configuration converter loading.
> >> >>
> >> >> Dennis, do you work actually on maven-maven1-plugin?
> >> >
> >> > Oh sorry Emmanuel, I misread your mail the first time.
> >> >
> >> > I will check out maven-model-converter and see what you have done.
> >>
> >> yes, all the code is in maven-model-converter now. I need to merge it
> >> in maven 2.0.x branch, I'll do
> >> it tomorrow morning.
> >>
> >> >
> >> > There only seems to be the mojo left in the sandbox. I will have a look
> >> > at moving that to the maven-one-plugin and making it use the code that
> >> > has now moved to maven-model-converter. OK?
> >>
> >> The mojo is always in sandbox and we need to modify it, so it will use
> >> maven-model-converter, and
> >> yes, maven-one-plugin will be a better place for it.
> >>
> >> >
> >> > One other thing that I have left on my todo list, besides the stuff I
> >> > wrote about in the other mail, is to make the
> >> > PluginConfigurationConverters into plexus components.
> >>
> >> it's done :-)
> >>
> >> >
> >> > I have some other stuff that is not yet committed. Will go through it
> >> > and see how much there is and if it's ready to be checked in or not.
> >> >
> >> > Would it be possible for me to get svn write access to
> >> > maven-model-converter or do you prefer if I submit patches?
> >> >
> >>
> >> For the moment, you can send a patch and we'll see with the pmc if you
> >> can have access to
> >> maven-model-converter.
> >>
> >> Emmanuel
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
"If you even dream of beating me you'd better wake up and apologize" -
Muhammad Ali
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
The mojo that we need to move under maven-one-plugin convert a m1 project
(project.xml+project.properties) to a m2 project. If some properties are found about some plugins in
properties file, the plugin is added with the conf in the pom.xml too.
maven-maven1-plugin allow to package a m1 plugin with m2
Emmanuel
Dion Gillard a écrit :
> Guys,
>
> what does the plugin do?
>
> On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
>>
>>
>> Dennis Lundberg a écrit :
>> > Emmanuel Venisse wrote:
>> >> Hi,
>> >>
>> >> I'm starting to migrate all the code from
>> >> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
>> >> modifications on plugin configuration converter loading.
>> >>
>> >> Dennis, do you work actually on maven-maven1-plugin?
>> >
>> > Oh sorry Emmanuel, I misread your mail the first time.
>> >
>> > I will check out maven-model-converter and see what you have done.
>>
>> yes, all the code is in maven-model-converter now. I need to merge it
>> in maven 2.0.x branch, I'll do
>> it tomorrow morning.
>>
>> >
>> > There only seems to be the mojo left in the sandbox. I will have a look
>> > at moving that to the maven-one-plugin and making it use the code that
>> > has now moved to maven-model-converter. OK?
>>
>> The mojo is always in sandbox and we need to modify it, so it will use
>> maven-model-converter, and
>> yes, maven-one-plugin will be a better place for it.
>>
>> >
>> > One other thing that I have left on my todo list, besides the stuff I
>> > wrote about in the other mail, is to make the
>> > PluginConfigurationConverters into plexus components.
>>
>> it's done :-)
>>
>> >
>> > I have some other stuff that is not yet committed. Will go through it
>> > and see how much there is and if it's ready to be checked in or not.
>> >
>> > Would it be possible for me to get svn write access to
>> > maven-model-converter or do you prefer if I submit patches?
>> >
>>
>> For the moment, you can send a patch and we'll see with the pmc if you
>> can have access to
>> maven-model-converter.
>>
>> Emmanuel
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dion Gillard <di...@gmail.com>.
Guys,
what does the plugin do?
On 7/20/06, Emmanuel Venisse <em...@venisse.net> wrote:
>
>
> Dennis Lundberg a écrit :
> > Emmanuel Venisse wrote:
> >> Hi,
> >>
> >> I'm starting to migrate all the code from
> >> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
> >> modifications on plugin configuration converter loading.
> >>
> >> Dennis, do you work actually on maven-maven1-plugin?
> >
> > Oh sorry Emmanuel, I misread your mail the first time.
> >
> > I will check out maven-model-converter and see what you have done.
>
> yes, all the code is in maven-model-converter now. I need to merge it in maven 2.0.x branch, I'll do
> it tomorrow morning.
>
> >
> > There only seems to be the mojo left in the sandbox. I will have a look
> > at moving that to the maven-one-plugin and making it use the code that
> > has now moved to maven-model-converter. OK?
>
> The mojo is always in sandbox and we need to modify it, so it will use maven-model-converter, and
> yes, maven-one-plugin will be a better place for it.
>
> >
> > One other thing that I have left on my todo list, besides the stuff I
> > wrote about in the other mail, is to make the
> > PluginConfigurationConverters into plexus components.
>
> it's done :-)
>
> >
> > I have some other stuff that is not yet committed. Will go through it
> > and see how much there is and if it's ready to be checked in or not.
> >
> > Would it be possible for me to get svn write access to
> > maven-model-converter or do you prefer if I submit patches?
> >
>
> For the moment, you can send a patch and we'll see with the pmc if you can have access to
> maven-model-converter.
>
> Emmanuel
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
"If you even dream of beating me you'd better wake up and apologize" -
Muhammad Ali
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Trygve Laugstøl <tr...@apache.org>.
Emmanuel Venisse wrote:
> oh yes :-)
We're old school Emmanuel, I still use the old version too often..
--
Trygve
> Emmanuel
>
> Brett Porter a écrit :
>
>> On 28/07/2006 7:27 PM, Emmanuel Venisse wrote:
>>
>>> /**
>>> * @parameter
>>> expression="${component.org.apache.maven.model.converter.Maven2Converter}"
>>>
>>> * @required
>>> */
>>> private Maven1Converter converter;
>>
>>
>> or better:
>>
>> /**
>> * @component
>> */
>> private Maven1Converter converter;
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
oh yes :-)
Emmanuel
Brett Porter a écrit :
> On 28/07/2006 7:27 PM, Emmanuel Venisse wrote:
>> /**
>> * @parameter
>> expression="${component.org.apache.maven.model.converter.Maven2Converter}"
>>
>> * @required
>> */
>> private Maven1Converter converter;
>
> or better:
>
> /**
> * @component
> */
> private Maven1Converter converter;
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Brett Porter wrote:
> On 28/07/2006 7:27 PM, Emmanuel Venisse wrote:
>> /**
>> * @parameter
>> expression="${component.org.apache.maven.model.converter.Maven2Converter}"
>>
>> * @required
>> */
>> private Maven1Converter converter;
>
> or better:
>
> /**
> * @component
> */
> private Maven1Converter converter;
>
Thanks!
Now it's running again. I wanted to make sure the mojo worked correctly
before starting to move it to the maven-one-plugin.
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Brett Porter <br...@apache.org>.
On 28/07/2006 7:27 PM, Emmanuel Venisse wrote:
> /**
> * @parameter
> expression="${component.org.apache.maven.model.converter.Maven2Converter}"
> * @required
> */
> private Maven1Converter converter;
or better:
/**
* @component
*/
private Maven1Converter converter;
--
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
Dennis Lundberg a écrit :
> I use it through the maven-maven1-plugin like this:
>
> Maven1Converter converter = new Maven1Converter();
> converter.setBasedir( basedir );
>
> try
> {
> converter.execute();
> }
> catch ( ProjectConverterException e )
> {
> throw new MojoExecutionException( "An exception occured
> while converting the Maven 1 project", e );
> }
>
Ok, you can't use "new" for plexus components, you must lookup them. If you don't lookup it, fields
aren't initilialized with requirements.
In your mojo, add this:
/**
* @parameter expression="${component.org.apache.maven.model.converter.Maven2Converter}"
* @required
*/
private Maven1Converter converter;
...
converter.execute();
...
> Is there a way for me to test it on the command line using just
> maven-model-converter?
>
No, but I'll add a junit test for it.
Emmanuel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@mdh.se>.
I use it through the maven-maven1-plugin like this:
Maven1Converter converter = new Maven1Converter();
converter.setBasedir( basedir );
try
{
converter.execute();
}
catch ( ProjectConverterException e )
{
throw new MojoExecutionException( "An exception occured
while converting the Maven 1 project", e );
}
Is there a way for me to test it on the command line using just
maven-model-converter?
--
Dennis Lundberg
Emmanuel Venisse wrote:
> Yes it works fine for me. How do you use it?
>
> Emmanuel
>
> Dennis Lundberg a écrit :
>> Emmanuel,
>>
>> I'm still not getting the plexus components to work, even after your
>> latest commits. Is it working for you?
>>
>> [DEBUG] Trace
>> java.lang.NullPointerException
>> at
>> org.apache.maven.model.converter.Maven1Converter.execute(Maven1Converter.java:122)
>>
>> at
>> org.apache.maven.maven1converter.PomV3ConvertMojo.execute(PomV3ConvertMojo.java:58)
>>
>> at
>> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:219)
>>
>> at
>> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
>>
>> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
>> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
>> at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>
>> at java.lang.reflect.Method.invoke(Method.java:324)
>> at
>> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>> at
>> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
Yes it works fine for me. How do you use it?
Emmanuel
Dennis Lundberg a écrit :
> Emmanuel,
>
> I'm still not getting the plexus components to work, even after your
> latest commits. Is it working for you?
>
> [DEBUG] Trace
> java.lang.NullPointerException
> at
> org.apache.maven.model.converter.Maven1Converter.execute(Maven1Converter.java:122)
>
> at
> org.apache.maven.maven1converter.PomV3ConvertMojo.execute(PomV3ConvertMojo.java:58)
>
> at
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:219)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
>
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:324)
> at
> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Emmanuel,
I'm still not getting the plexus components to work, even after your
latest commits. Is it working for you?
[DEBUG] Trace
java.lang.NullPointerException
at
org.apache.maven.model.converter.Maven1Converter.execute(Maven1Converter.java:122)
at
org.apache.maven.maven1converter.PomV3ConvertMojo.execute(PomV3ConvertMojo.java:58)
at
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:219)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
Dennis Lundberg
Dennis Lundberg wrote:
> Emmanuel Venisse wrote:
>>
>>
>> Dennis Lundberg a écrit :
>>> Emmanuel Venisse wrote:
>>>> Hi,
>>>>
>>>> I'm starting to migrate all the code from
>>>> sandbox/plugins/maven-maven1-plugin to maven-model-converter with
>>>> some modifications on plugin configuration converter loading.
>>>>
>>>> Dennis, do you work actually on maven-maven1-plugin?
>>>
>>> Oh sorry Emmanuel, I misread your mail the first time.
>>>
>>> I will check out maven-model-converter and see what you have done.
>>
>> yes, all the code is in maven-model-converter now. I need to merge it
>> in maven 2.0.x branch, I'll do it tomorrow morning.
>>
>>>
>>> There only seems to be the mojo left in the sandbox. I will have a
>>> look at moving that to the maven-one-plugin and making it use the
>>> code that has now moved to maven-model-converter. OK?
>>
>> The mojo is always in sandbox and we need to modify it, so it will use
>> maven-model-converter, and yes, maven-one-plugin will be a better
>> place for it.
>
> I have gone ahead and changed the maven-maven1-plugin in the sandbox to
> use the code that is in maven-model-converter. But I can't get the
> plexus components to work any more. I get a NullPointerException when
> trying to access them:
>
> [ERROR] FATAL ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO] null
> [INFO]
> ------------------------------------------------------------------------
> [DEBUG] Trace
> java.lang.NullPointerException
> at
> org.apache.maven.model.converter.Maven1Converter.execute(Maven1Converter.java:114)
>
> at
> org.apache.maven.maven1converter.PomV3ConvertMojo.execute(PomV3ConvertMojo.java:58)
>
> at
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:219)
>
> at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
>
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:324)
> at
> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
>
>
> Do you have any idea what might be wrong?
>
>>>
>>> One other thing that I have left on my todo list, besides the stuff I
>>> wrote about in the other mail, is to make the
>>> PluginConfigurationConverters into plexus components.
>>
>> it's done :-)
>
> Thanks!
>
>>>
>>> I have some other stuff that is not yet committed. Will go through it
>>> and see how much there is and if it's ready to be checked in or not.
>>>
>>> Would it be possible for me to get svn write access to
>>> maven-model-converter or do you prefer if I submit patches?
>>>
>>
>> For the moment, you can send a patch and we'll see with the pmc if you
>> can have access to maven-model-converter.
>>
>> Emmanuel
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Emmanuel Venisse wrote:
>
>
> Dennis Lundberg a écrit :
>> Emmanuel Venisse wrote:
>>> Hi,
>>>
>>> I'm starting to migrate all the code from
>>> sandbox/plugins/maven-maven1-plugin to maven-model-converter with
>>> some modifications on plugin configuration converter loading.
>>>
>>> Dennis, do you work actually on maven-maven1-plugin?
>>
>> Oh sorry Emmanuel, I misread your mail the first time.
>>
>> I will check out maven-model-converter and see what you have done.
>
> yes, all the code is in maven-model-converter now. I need to merge it in
> maven 2.0.x branch, I'll do it tomorrow morning.
>
>>
>> There only seems to be the mojo left in the sandbox. I will have a
>> look at moving that to the maven-one-plugin and making it use the code
>> that has now moved to maven-model-converter. OK?
>
> The mojo is always in sandbox and we need to modify it, so it will use
> maven-model-converter, and yes, maven-one-plugin will be a better place
> for it.
I have gone ahead and changed the maven-maven1-plugin in the sandbox to
use the code that is in maven-model-converter. But I can't get the
plexus components to work any more. I get a NullPointerException when
trying to access them:
[ERROR] FATAL ERROR
[INFO]
------------------------------------------------------------------------
[INFO] null
[INFO]
------------------------------------------------------------------------
[DEBUG] Trace
java.lang.NullPointerException
at
org.apache.maven.model.converter.Maven1Converter.execute(Maven1Converter.java:114)
at
org.apache.maven.maven1converter.PomV3ConvertMojo.execute(PomV3ConvertMojo.java:58)
at
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:412)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:306)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:219)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:322)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:115)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:256)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Do you have any idea what might be wrong?
>>
>> One other thing that I have left on my todo list, besides the stuff I
>> wrote about in the other mail, is to make the
>> PluginConfigurationConverters into plexus components.
>
> it's done :-)
Thanks!
>>
>> I have some other stuff that is not yet committed. Will go through it
>> and see how much there is and if it's ready to be checked in or not.
>>
>> Would it be possible for me to get svn write access to
>> maven-model-converter or do you prefer if I submit patches?
>>
>
> For the moment, you can send a patch and we'll see with the pmc if you
> can have access to maven-model-converter.
>
> Emmanuel
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Emmanuel Venisse <em...@venisse.net>.
Dennis Lundberg a écrit :
> Emmanuel Venisse wrote:
>> Hi,
>>
>> I'm starting to migrate all the code from
>> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
>> modifications on plugin configuration converter loading.
>>
>> Dennis, do you work actually on maven-maven1-plugin?
>
> Oh sorry Emmanuel, I misread your mail the first time.
>
> I will check out maven-model-converter and see what you have done.
yes, all the code is in maven-model-converter now. I need to merge it in maven 2.0.x branch, I'll do
it tomorrow morning.
>
> There only seems to be the mojo left in the sandbox. I will have a look
> at moving that to the maven-one-plugin and making it use the code that
> has now moved to maven-model-converter. OK?
The mojo is always in sandbox and we need to modify it, so it will use maven-model-converter, and
yes, maven-one-plugin will be a better place for it.
>
> One other thing that I have left on my todo list, besides the stuff I
> wrote about in the other mail, is to make the
> PluginConfigurationConverters into plexus components.
it's done :-)
>
> I have some other stuff that is not yet committed. Will go through it
> and see how much there is and if it's ready to be checked in or not.
>
> Would it be possible for me to get svn write access to
> maven-model-converter or do you prefer if I submit patches?
>
For the moment, you can send a patch and we'll see with the pmc if you can have access to
maven-model-converter.
Emmanuel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Emmanuel Venisse wrote:
> Hi,
>
> I'm starting to migrate all the code from
> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
> modifications on plugin configuration converter loading.
>
> Dennis, do you work actually on maven-maven1-plugin?
Oh sorry Emmanuel, I misread your mail the first time.
I will check out maven-model-converter and see what you have done.
There only seems to be the mojo left in the sandbox. I will have a look
at moving that to the maven-one-plugin and making it use the code that
has now moved to maven-model-converter. OK?
One other thing that I have left on my todo list, besides the stuff I
wrote about in the other mail, is to make the
PluginConfigurationConverters into plexus components.
I have some other stuff that is not yet committed. Will go through it
and see how much there is and if it's ready to be checked in or not.
Would it be possible for me to get svn write access to
maven-model-converter or do you prefer if I submit patches?
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven1 project converter
Posted by Dennis Lundberg <de...@apache.org>.
Emmanuel Venisse wrote:
> Hi,
>
> I'm starting to migrate all the code from
> sandbox/plugins/maven-maven1-plugin to maven-model-converter with some
> modifications on plugin configuration converter loading.
>
> Dennis, do you work actually on maven-maven1-plugin?
Yes, it's pretty much completed. It needs some documentation and really
should be moved to maven-one-plugin, as someone suggested earlier. There
are always more stuff to do, but I think it is ready for (at least) a
beta release. There is one thing that needs to be done first though and
that is to repackage the source as it is currently in the wrong package.
What are your thoughts on moving this forward?
My suggested plan would be:
1. Repackage source code
2. Move the code from sandbox to maven-one-plugin
3. Write basic documentation
4. Release a beta
5. Wait for user feedback, as it has had minimal testing
6. Fix bugs
7. Release stable version
Any thoughts?
I'll get starting on this. Also need to check the status of the
maven-one-plugin.
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org