You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/06 15:43:07 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1375: libc: Always declare getenv, link/symlink and atexit/on_exit

xiaoxiang781216 opened a new pull request #1375:
URL: https://github.com/apache/incubator-nuttx/pull/1375


   ## Summary
   since many c++ library implementation reference these symbols by using ::xxx but never
   really use them, the declaration avoid the unused code is pulled into the final binary
   
   ## Impact
   No, only the conditional guard is removed.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1375: libc: Always declare getenv, link/symlink and atexit/on_exit

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1375:
URL: https://github.com/apache/incubator-nuttx/pull/1375#issuecomment-655148806


   Should the CONFIGs be removed as well from their respective Kconfig files?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1375: libc: Always declare getenv, link/symlink and atexit/on_exit

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1375:
URL: https://github.com/apache/incubator-nuttx/pull/1375#issuecomment-655249566


   > Should the CONFIGs be removed as well from their respective Kconfig files?
   
   No, since these functions are still optional. This patch just fix the c++ library which blindly declare(using ::) functions but not really use them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1375: libc: Always declare getenv, link/symlink and atexit/on_exit

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1375:
URL: https://github.com/apache/incubator-nuttx/pull/1375


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org