[PR] ensures instrumented cache is recording stats [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner opened a new pull request, #4552:
URL: https://github.com/apache/accumulo/pull/4552

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ensures instrumented cache is recording stats [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on PR #4552:
URL: https://github.com/apache/accumulo/pull/4552#issuecomment-2112764815

   > This seems ok to me, is there any risk with having the state check being added in a minor release of causing anything to break on upgrade that we would not want to happen?
   
   I think the risk of this change is low because its one part of code checking another part of the code that is not configurable.  So the user can not do anything ATM that would trigger this new check.  It should only be triggered by a code change that disables recording stats when the cache is constructed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ensures instrumented cache is recording stats [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner merged PR #4552:
URL: https://github.com/apache/accumulo/pull/4552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ensures instrumented cache is recording stats [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on PR #4552:
URL: https://github.com/apache/accumulo/pull/4552#issuecomment-2106000925

   The motivation behind this is that in the past the scan servers tablet metadata cache was instrumented w/ micrometere but not recording stats.  Was attempting to use the cache metrics and they were zero and/or non existent.  Spent a long time tracking down why instrumentation was not working (was looking at micrometer source code first thinking there was a bug there).  So this change is an attempt to catch future changes where the cache is changed to no longer record stats.  Tried to think of a more general way to catch this mismatch between cache builder and cahce insturmention that could catch the problem anywhere in the Accumulo code base, but could not think of anything.  So this change adds a check to the place where I saw it and it caused me problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org