You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/28 19:51:14 UTC
[GitHub] [shardingsphere] 726411951 opened a new pull request, #18674: [Issue #18055] The document is not ture about sharding rules
726411951 opened a new pull request, #18674:
URL: https://github.com/apache/shardingsphere/pull/18674
Fixes #18055.
Changes proposed in this pull request:
- add '.rules' in /docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#discussion_r909143992
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.cn.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # 广播表规则列
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # 广播表规则列表
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # 广播表规则列表
-spring.shardingsphere.sharding.default-database-strategy.xxx= # 默认数据库分片策略
-spring.shardingsphere.sharding.default-table-strategy.xxx= # 默认表分片策略
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # 默认分布式序列策略
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # 默认数据库分片策略
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # 默认表分片策略
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # 默认分布式序列策略
Review Comment:
This is the change history, is it need to modify?
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.en.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # Broadcast tables
-spring.shardingsphere.sharding.default-database-strategy.xxx= # Default strategy for database sharding
-spring.shardingsphere.sharding.default-table-strategy.xxx= # Default strategy for table sharding
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # Default strategy for database sharding
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # Default strategy for table sharding
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
Review Comment:
This is the change history, is it need to modify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 726411951 commented on pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
726411951 commented on PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#issuecomment-1169904234
@terrymanu Hi，I have reverted the changes about history files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 726411951 commented on a diff in pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
726411951 commented on code in PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#discussion_r909150465
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.cn.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # 广播表规则列
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # 广播表规则列表
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # 广播表规则列表
-spring.shardingsphere.sharding.default-database-strategy.xxx= # 默认数据库分片策略
-spring.shardingsphere.sharding.default-table-strategy.xxx= # 默认表分片策略
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # 默认分布式序列策略
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # 默认数据库分片策略
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # 默认表分片策略
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # 默认分布式序列策略
Review Comment:
Yes, it's used in '/examples' like [Line 34](https://github.com/apache/shardingsphere/blob/c89217636d579a050d59a95e0e532980d5488dd3/examples/shardingsphere-jdbc-example/single-feature-example/extension-example/custom-sharding-algortihm-example/spi-based-sharding-algorithm-example/spi-based-sharding-spring-boot-jpa-example/src/main/resources/application-sharding-databases-tables.properties)
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.en.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # Broadcast tables
-spring.shardingsphere.sharding.default-database-strategy.xxx= # Default strategy for database sharding
-spring.shardingsphere.sharding.default-table-strategy.xxx= # Default strategy for table sharding
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # Default strategy for database sharding
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # Default strategy for table sharding
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
Review Comment:
Yes, it's used in '/examples' like [Line 34](https://github.com/apache/shardingsphere/blob/c89217636d579a050d59a95e0e532980d5488dd3/examples/shardingsphere-jdbc-example/single-feature-example/extension-example/custom-sharding-algortihm-example/spi-based-sharding-algorithm-example/spi-based-sharding-spring-boot-jpa-example/src/main/resources/application-sharding-databases-tables.properties)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 726411951 commented on a diff in pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
726411951 commented on code in PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#discussion_r909221172
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.en.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # Broadcast tables
-spring.shardingsphere.sharding.default-database-strategy.xxx= # Default strategy for database sharding
-spring.shardingsphere.sharding.default-table-strategy.xxx= # Default strategy for table sharding
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # Default strategy for database sharding
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # Default strategy for table sharding
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
Review Comment:
I got it, it is not necessary to modify and I will update later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#discussion_r909215912
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.en.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # Broadcast tables
-spring.shardingsphere.sharding.default-database-strategy.xxx= # Default strategy for database sharding
-spring.shardingsphere.sharding.default-table-strategy.xxx= # Default strategy for table sharding
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # Default strategy for database sharding
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # Default strategy for table sharding
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
Review Comment:
What I mean is the doc is for history version, not for current version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 726411951 commented on a diff in pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
726411951 commented on code in PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674#discussion_r909221172
##########
docs/document/content/reference/api-change-history/shardingsphere-jdbc/spring-boot-starter.en.md:
##########
@@ -49,9 +49,9 @@ spring.shardingsphere.rules.sharding.broadcast-tables[0]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[1]= # Broadcast tables
spring.shardingsphere.rules.sharding.broadcast-tables[x]= # Broadcast tables
-spring.shardingsphere.sharding.default-database-strategy.xxx= # Default strategy for database sharding
-spring.shardingsphere.sharding.default-table-strategy.xxx= # Default strategy for table sharding
-spring.shardingsphere.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
+spring.shardingsphere.rules.sharding.default-database-strategy.xxx= # Default strategy for database sharding
+spring.shardingsphere.rules.sharding.default-table-strategy.xxx= # Default strategy for table sharding
+spring.shardingsphere.rules.sharding.default-key-generate-strategy.xxx= # Default Key generator strategy
Review Comment:
I got it, it is not necessary to modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18674: [Issue #18055] The document is not ture about sharding rules
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18674:
URL: https://github.com/apache/shardingsphere/pull/18674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org