You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by omkreddy <gi...@git.apache.org> on 2018/01/19 18:38:58 UTC
[GitHub] storm pull request #2520: STORM-2903: Fix possible NullPointerException in A...
GitHub user omkreddy opened a pull request:
https://github.com/apache/storm/pull/2520
STORM-2903: Fix possible NullPointerException in AbstractHadoopAutoCreds and doc cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omkreddy/storm AUTO-CREDS-CLEANUP-MASTER
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2520
----
commit fd080d99d5c4d483e6a1149ad3edc0b5a7732412
Author: Manikumar Reddy <ma...@...>
Date: 2018-01-19T18:10:37Z
STORM-2903: Fix possible NullPointerException in AbstractHadoopAutoCreds and doc cleanups
----
---
[GitHub] storm pull request #2520: STORM-2903: Fix possible NullPointerException in A...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2520#discussion_r162780179
--- Diff: external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractHadoopAutoCreds.java ---
@@ -113,10 +113,14 @@ private void addTokensToUGI(Subject subject) {
if (allTokens != null) {
for (Token<? extends TokenIdentifier> token : allTokens) {
try {
+ if (token == null) {
+ LOG.debug("Ignoring null token");
+ continue;
+ }
--- End diff --
So in what scenario the token can be null ?
---
[GitHub] storm pull request #2520: STORM-2903: Fix possible NullPointerException in A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2520
---