You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/27 07:00:30 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #1151: build: create build-parent-it pom to collect common integration tests set-up
lburgazzoli opened a new pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1151: build: create build-parent-it pom to collect common integration tests set-up
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151#discussion_r415621993
##########
File path: tooling/create-extension-templates/parent-pom.xml
##########
@@ -23,9 +23,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-build-parent</artifactId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
<version>[=version]</version>
- <relativePath>../../poms/build-parent/pom.xml</relativePath>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
Review comment:
oh sorry, I changed the wrong one, maybe having a structure similar to the the final directory layout could help a little
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1151: build: create build-parent-it pom to collect common integration tests set-up
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151#discussion_r415628694
##########
File path: tooling/create-extension-templates/parent-pom.xml
##########
@@ -23,9 +23,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-build-parent</artifactId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
<version>[=version]</version>
- <relativePath>../../poms/build-parent/pom.xml</relativePath>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
Review comment:
> having a structure similar to the the final directory layout could help a little
That's probably doable if the config of the `create-extension` mojo is adjusted too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1151: build: create build-parent-it pom to collect common integration tests set-up
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151#discussion_r415624094
##########
File path: tooling/create-extension-templates/parent-pom.xml
##########
@@ -23,9 +23,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-build-parent</artifactId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
<version>[=version]</version>
- <relativePath>../../poms/build-parent/pom.xml</relativePath>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
Review comment:
@ppalaga done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1151: build: create build-parent-it pom to collect common integration tests set-up
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151#discussion_r415613730
##########
File path: tooling/create-extension-templates/parent-pom.xml
##########
@@ -23,9 +23,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-build-parent</artifactId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
<version>[=version]</version>
- <relativePath>../../poms/build-parent/pom.xml</relativePath>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
Review comment:
I think this should stay as is. This the template for the parent of runtime and deployment modules.
The template that needs change is `tooling/create-extension-templates/integration-test-pom.xml`. I think we can hardcode the artifactId `camel-quarkus-build-parent-it` there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org