[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #315: [WIP] Incremental processing prototype

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #315: [WIP] Incremental processing prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r354109564
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/Table.java
 ##########
 @@ -44,6 +44,15 @@
    */
   TableScan newScan();
 
+
+  /**
+   * @param fromSnapshotId - the last snapshot id read by the user, exclusive
+   * @param toSnapshotId - read incremental data upto this snapshot id
+   * @return a table scan which can read incremental data from {@param fromSnapshotId}
+   * exclusive and up to {@toSnapshotId} inclusive
+   */
+  TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId);
 
 Review comment:
   I'm not sure whether {{newDeltaScan}} fits here. Since this is not a pure delta and is more closely resembles only the appends between two snapshots [E.g as commented below maybe we will have to throw exceptions for overwrites and deletes?]
   
   Maybe it is best to rename it as {{appendsBetween}} as @rdblue mentions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org