[jira] [Commented] (CASSANDRA-15781) Fix flakiness of DecayingEstimatedHistogramReservoirTest#testStriping and apply the same "fix" to other tests

["Eduard Tudenhoefner (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098809#comment-17098809 ] 

Eduard Tudenhoefner commented on CASSANDRA-15781:
-------------------------------------------------

changes LGTM

> Fix flakiness of DecayingEstimatedHistogramReservoirTest#testStriping and apply the same "fix" to other tests
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15781
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15781
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/unit
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Normal
>             Fix For: 4.0
>
>
> The unit test {{DecayingEstimatedHistogramReservoirTest#testStriping}} is flaky, especially when many tests are running concurrently, because the used thread-pool can still be running when the assertions are tested (i.e. the {{ExecutorService.awaitTermination()}} returned false).
> The "fix" is rather a band aid: extend the wait-period to 1 minute, check the return value of {{awaitTermination}} and apply the same change to some other tests that _might_ be affected as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org